Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1428829AbdDYJkV (ORCPT ); Tue, 25 Apr 2017 05:40:21 -0400 Received: from mail-lf0-f44.google.com ([209.85.215.44]:34986 "EHLO mail-lf0-f44.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1428789AbdDYJkL (ORCPT ); Tue, 25 Apr 2017 05:40:11 -0400 Subject: Re: [PATCH 2/2] ARM: dts: Add the ethernet and ethernet PHY to the cygnus core DT. To: Eric Anholt , Florian Fainelli , Vivien Didelot , Andrew Lunn , netdev@vger.kernel.org, Rob Herring , Mark Rutland , devicetree@vger.kernel.org References: <20170424215022.30382-1-eric@anholt.net> <20170424215022.30382-3-eric@anholt.net> Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, bcm-kernel-feedback-list@broadcom.com, Ray Jui , Scott Branden , Jon Mason From: Sergei Shtylyov Message-ID: Date: Tue, 25 Apr 2017 12:40:08 +0300 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.8.0 MIME-Version: 1.0 In-Reply-To: <20170424215022.30382-3-eric@anholt.net> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1550 Lines: 61 Hello. On 4/25/2017 12:50 AM, Eric Anholt wrote: > Cygnus has a single amac controller connected to the B53 switch with 2 > PHYs. On the BCM911360_EP platform, those two PHYs are connected to > the external ethernet jacks. My spell checker trips on "amac" and "ethernet" -- perhaps they need capitalization? > Signed-off-by: Eric Anholt > --- > arch/arm/boot/dts/bcm-cygnus.dtsi | 60 ++++++++++++++++++++++++++++++++++ > arch/arm/boot/dts/bcm911360_entphn.dts | 8 +++++ > 2 files changed, 68 insertions(+) > > diff --git a/arch/arm/boot/dts/bcm-cygnus.dtsi b/arch/arm/boot/dts/bcm-cygnus.dtsi > index 009f1346b817..318899df9972 100644 > --- a/arch/arm/boot/dts/bcm-cygnus.dtsi > +++ b/arch/arm/boot/dts/bcm-cygnus.dtsi > @@ -142,6 +142,56 @@ > interrupts = <0>; > }; > > + mdio: mdio@18002000 { > + compatible = "brcm,iproc-mdio"; > + reg = <0x18002000 0x8>; > + #size-cells = <1>; > + #address-cells = <0>; > + > + gphy0: eth-gphy@0 { The node anmes must be generic, the DT spec has standardized "ethernet-phy" name for this case. > + reg = <0>; > + max-speed = <1000>; > + }; > + > + gphy1: eth-gphy@1 { > + reg = <1>; > + max-speed = <1000>; > + }; > + }; [...] > @@ -295,6 +345,16 @@ > status = "disabled"; > }; > > + eth0: enet@18042000 { > + compatible = "brcm,amac"; > + reg = <0x18042000 0x1000>, > + <0x18110000 0x1000>; > + reg-names = "amac_base", "idm_base"; I don't think "_base" suffixes are necessary here. [...] MBR, Sergei