Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1167754AbdDYKJV (ORCPT ); Tue, 25 Apr 2017 06:09:21 -0400 Received: from david.siemens.de ([192.35.17.14]:42805 "EHLO david.siemens.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753147AbdDYKJP (ORCPT ); Tue, 25 Apr 2017 06:09:15 -0400 Subject: Re: [PATCH] stmmac: Add support for SIMATIC IOT2000 platform To: Andy Shevchenko References: <8c536123-6189-e0b6-1977-dc7a521718dd@siemens.com> <42fd4a72-526c-cbd9-52db-9d8b495035ee@siemens.com> Cc: Giuseppe Cavallaro , Alexandre Torgue , netdev , Linux Kernel Mailing List , Sascha Weisenberger From: Jan Kiszka Message-ID: <3eae5626-1ef2-03ae-635e-27faed085c68@siemens.com> Date: Tue, 25 Apr 2017 12:09:09 +0200 User-Agent: Mozilla/5.0 (X11; U; Linux i686 (x86_64); de; rv:1.8.1.12) Gecko/20080226 SUSE/2.0.0.12-1.1 Thunderbird/2.0.0.12 Mnenhy/0.7.5.666 MIME-Version: 1.0 In-Reply-To: <42fd4a72-526c-cbd9-52db-9d8b495035ee@siemens.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2134 Lines: 62 On 2017-04-25 12:07, Jan Kiszka wrote: > On 2017-04-25 11:46, Andy Shevchenko wrote: >> On Tue, Apr 25, 2017 at 12:00 PM, Jan Kiszka wrote: >>> On 2017-04-25 09:30, Andy Shevchenko wrote: >>>> On Tue, Apr 25, 2017 at 8:44 AM, Jan Kiszka wrote: >>>>> On 2017-04-24 23:27, Andy Shevchenko wrote: >>>>>> On Mon, Apr 24, 2017 at 10:27 PM, Jan Kiszka wrote: >>>>>>> The IOT2000 is industrial controller platform, derived from the Intel >>>>>>> Galileo Gen2 board. The variant IOT2020 comes with one LAN port, the >>>>>>> IOT2040 has two of them. They can be told apart based on the board asset >>>>>>> tag in the DMI table. >>>> >>>>>>> + const char *asset_tag; >>>>>> >>>>>> I guess this is redundant. See below. >>>>>> >>>>>>> + { >>>>>>> + .name = "SIMATIC IOT2000", >>>>>>> + .asset_tag = "6ES7647-0AA00-0YA2", >>>>>>> + .func = 6, >>>>>>> + .phy_addr = 1, >>>>>>> + }, >>>>>> >>>>>> The below has same definition disregard on asset_tag. >>>>>> >>>>> >>>>> There is a small difference in the asset tag, just not at the last digit >>>>> where one may expect it, look: >>>>> >>>>> ...-0YA2 -> IOT2020 >>>>> ...-1YA2 -> IOT2040 >>>> >>>> Yes. And how does it change my statement? You may use one record here >>>> instead of two. >>> >>> How? Please be more verbose in your comments. >> >> { >> .name = "SIMATIC IOT2000", >> .func = 6, >> .phy_addr = 1, >> }, >> { >> .name = "SIMATIC IOT2000", >> .func = 7, >> .phy_addr = 1, >> }, >> >> That's all what you need. > > Nope. Again: the asset tag is the way to tell both apart AND to ensure > that we do not match on future devices. To be more verbose: your version (which is our old one) would even enable the second, not connected port on the IOT2020. Incorrectly. Plus the risk to match different future devices. Jan -- Siemens AG, Corporate Technology, CT RDA ITP SES-DE Corporate Competence Center Embedded Linux