Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1947115AbdDYLmc (ORCPT <rfc822;w@1wt.eu>);
        Tue, 25 Apr 2017 07:42:32 -0400
Received: from mail-qt0-f177.google.com ([209.85.216.177]:33395 "EHLO
        mail-qt0-f177.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1947075AbdDYLmX (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Tue, 25 Apr 2017 07:42:23 -0400
MIME-Version: 1.0
In-Reply-To: <3eae5626-1ef2-03ae-635e-27faed085c68@siemens.com>
References: <8c536123-6189-e0b6-1977-dc7a521718dd@siemens.com>
 <CAHp75VcdpOXa+aQ6-iKamTAbX9KGZOWpukygSUS7Ef_E3UNvuw@mail.gmail.com>
 <feb4856b-fb66-3861-2121-d2834fb01899@siemens.com> <CAHp75VcTzBL4D6nobfDAPQOfEEp-RzBp4BANKYDSaaEtGCyj9A@mail.gmail.com>
 <d7216317-e749-1347-972f-28dfe57038c0@siemens.com> <CAHp75VfqC166E57nZRsx97EQCCGnqYTk+4nRX3H2-rsnCohPfQ@mail.gmail.com>
 <42fd4a72-526c-cbd9-52db-9d8b495035ee@siemens.com> <3eae5626-1ef2-03ae-635e-27faed085c68@siemens.com>
From: Andy Shevchenko <andy.shevchenko@gmail.com>
Date: Tue, 25 Apr 2017 14:42:22 +0300
Message-ID: <CAHp75Vd=TkJXnDYqctKCzRGvMX_Zt0i5eH8GcBz44e-T93aJ0A@mail.gmail.com>
Subject: Re: [PATCH] stmmac: Add support for SIMATIC IOT2000 platform
To: Jan Kiszka <jan.kiszka@siemens.com>
Cc: Giuseppe Cavallaro <peppe.cavallaro@st.com>,
        Alexandre Torgue <alexandre.torgue@st.com>,
        netdev <netdev@vger.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        Sascha Weisenberger <sascha.weisenberger@siemens.com>
Content-Type: text/plain; charset=UTF-8
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 1330
Lines: 38

On Tue, Apr 25, 2017 at 1:09 PM, Jan Kiszka <jan.kiszka@siemens.com> wrote:
> On 2017-04-25 12:07, Jan Kiszka wrote:
>> On 2017-04-25 11:46, Andy Shevchenko wrote:
>>> On Tue, Apr 25, 2017 at 12:00 PM, Jan Kiszka <jan.kiszka@siemens.com> wrote:
>>>> On 2017-04-25 09:30, Andy Shevchenko wrote:
>>>>> On Tue, Apr 25, 2017 at 8:44 AM, Jan Kiszka <jan.kiszka@siemens.com> wrote:
>>>>>> On 2017-04-24 23:27, Andy Shevchenko wrote:
>>>>>>> On Mon, Apr 24, 2017 at 10:27 PM, Jan Kiszka <jan.kiszka@siemens.com> wrote:

>>>        {
>>>                .name = "SIMATIC IOT2000",
>>>                .func = 6,
>>>                .phy_addr = 1,
>>>        },
>>>        {
>>>                .name = "SIMATIC IOT2000",
>>>                .func = 7,
>>>                .phy_addr = 1,
>>>        },
>>>
>>> That's all what you need.
>>
>> Nope. Again: the asset tag is the way to tell both apart AND to ensure
>> that we do not match on future devices.

> To be more verbose: your version (which is our old one) would even
> enable the second, not connected port on the IOT2020. Incorrectly.

So, name has 2000 for 2020 device? It's clear bug in DMI table you have. :-(

What else do you have in DMI which can be used to distinguish those devices?

> Plus
> the risk to match different future devices.

-- 
With Best Regards,
Andy Shevchenko