Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1948365AbdDYOro (ORCPT ); Tue, 25 Apr 2017 10:47:44 -0400 Received: from shards.monkeyblade.net ([184.105.139.130]:39822 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1948287AbdDYOrd (ORCPT ); Tue, 25 Apr 2017 10:47:33 -0400 Date: Tue, 25 Apr 2017 10:47:31 -0400 (EDT) Message-Id: <20170425.104731.631398016575024152.davem@davemloft.net> To: Jason@zx2c4.com Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, David.Laight@aculab.com, kernel-hardening@lists.openwall.com Subject: Re: [PATCH 1/5] skbuff: return -EMSGSIZE in skb_to_sgvec to prevent overflow From: David Miller In-Reply-To: <20170425140809.23881-1-Jason@zx2c4.com> References: <20170425140809.23881-1-Jason@zx2c4.com> X-Mailer: Mew version 6.7 on Emacs 24.5 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Tue, 25 Apr 2017 07:06:09 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 676 Lines: 22 From: "Jason A. Donenfeld" Date: Tue, 25 Apr 2017 16:08:05 +0200 > This is a defense-in-depth measure in response to bugs like > 4d6fa57b4dab0d77f4d8e9d9c73d1e63f6fe8fee. > > Signed-off-by: Jason A. Donenfeld Please refer to commits in the form: $(SHA1_ID) ("Commit header line.") That is, 12 bytes of SHA1_ID followed by the commit header line text in both double quotes and parenthesis, like this: 4d6fa57b4dab ("macsec: avoid heap overflow in skb_to_sgvec") Otherwise when changes get backported or applied to different trees, they have different SHA1_ID values. The commit header text removes any and all ambiguity. Thank you.