Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1948585AbdDYPAQ (ORCPT ); Tue, 25 Apr 2017 11:00:16 -0400 Received: from mail-pf0-f179.google.com ([209.85.192.179]:35244 "EHLO mail-pf0-f179.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1948528AbdDYPAI (ORCPT ); Tue, 25 Apr 2017 11:00:08 -0400 Date: Tue, 25 Apr 2017 16:00:05 +0100 From: Matt Fleming To: Jan Kiszka Cc: Ard Biesheuvel , linux-efi@vger.kernel.org, Linux Kernel Mailing List , Andy Shevchenko , "Bryan O'Donoghue" , Hock Leong Kweh , Borislav Petkov , Sascha Weisenberger Subject: Re: [PATCH v2 0/3] efi: add support for non-standard capsule headers Message-ID: <20170425150005.GR24360@codeblueprint.co.uk> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.24+41 (02bc14ed1569) (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1516 Lines: 40 On Wed, 19 Apr, at 08:32:59PM, Jan Kiszka wrote: > This picks up the patches Ard send before in [1], including the > "left-over" patches 6..8. > > As Ard suggested, I've taken updated patches 6 and 7 of him from [2] > which address reviewer comments. Furthermore, I've changed patch 8 to > factor out the Quark quirk logic from the overloaded > efi_capsule_setup_info as requested by Matt and also applied Andy's > suggestion to have a quirk dispatcher table with callbacks. > > Tested successfully on the IOT2040 - still without a working Galileo > board. > > Jan > > [1] http://www.spinics.net/lists/linux-efi/msg11194.html > [2] https://git.kernel.org/pub/scm/linux/kernel/git/ardb/linux.git/log/?h=quark-capsule > > Cc: Matt Fleming > > Ard Biesheuvel (2): > efi/capsule-loader: Redirect calls to efi_capsule_setup_info via weak > alias > efi/capsule-loader: Use page addresses rather than struct page > pointers > > Jan Kiszka (1): > efi/capsule: Add support for Quark security header > > arch/x86/platform/efi/quirks.c | 137 ++++++++++++++++++++++++++++++++++ > drivers/firmware/efi/Kconfig | 9 +++ > drivers/firmware/efi/capsule-loader.c | 66 ++++++++-------- > drivers/firmware/efi/capsule.c | 7 +- > include/linux/efi.h | 14 +++- > 5 files changed, 197 insertions(+), 36 deletions(-) OK, this looks like it's in good shape to me. Ard, are we waiting for anything else before we queue this up for v4.13?