Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1949024AbdDYPPi (ORCPT ); Tue, 25 Apr 2017 11:15:38 -0400 Received: from frisell.zx2c4.com ([192.95.5.64]:58891 "EHLO frisell.zx2c4.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1948892AbdDYPNs (ORCPT ); Tue, 25 Apr 2017 11:13:48 -0400 MIME-Version: 1.0 In-Reply-To: <20170425151248.GB25241@bistromath.localdomain> References: <20170421211448.16995-1-Jason@zx2c4.com> <20170425145340.GA25241@bistromath.localdomain> <20170425151248.GB25241@bistromath.localdomain> From: "Jason A. Donenfeld" Date: Tue, 25 Apr 2017 17:13:39 +0200 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH] macsec: avoid heap overflow in skb_to_sgvec To: Sabrina Dubroca Cc: Netdev , LKML , David Miller , stable@vger.kernel.org, security@kernel.org Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 353 Lines: 12 On Tue, Apr 25, 2017 at 5:12 PM, Sabrina Dubroca wrote: >> https://patchwork.ozlabs.org/patch/754861/ > > Yes, that prevents the overflow, but now you're just dropping > packets. Right, it's a so-called "defense-in-depth" measure. > I'll review that later, let's fix the overflow without > breaking connectivity for now. Agreed.