Subject: Re: [PATCH] hwmon: (ibmpowernv) Add min/max attributes and current
 sensors
To: Michael Ellerman <mpe@ellerman.id.au>,
        Shilpasri G Bhat <shilpa.bhat@linux.vnet.ibm.com>,
        Jean Delvare <jdelvare@suse.com>, Guenter Roeck <linux@roeck-us.net>,
        Paul Mackerras <paulus@samba.org>
References: <1492749112-32465-1-git-send-email-shilpa.bhat@linux.vnet.ibm.com>
 <d4e170f4-b8a0-480a-3095-779cf27650f3@kaod.org>
 <66e927c1-ceec-679d-8eaf-c6686b24b3a7@linux.vnet.ibm.com>
 <87a879ynrn.fsf@concordia.ellerman.id.au>
 <79e166e2-ed4b-7386-c07f-b02d68f133b5@kaod.org>
Cc: linux-hwmon@vger.kernel.org, linuxppc-dev@lists.ozlabs.org,
        linux-kernel@vger.kernel.org, svaidy@linux.vnet.ibm.com,
        ego@linux.vnet.ibm.com, akshay.adiga@linux.vnet.ibm.com,
        andrew@aj.id.au
From: =?UTF-8?Q?C=c3=a9dric_Le_Goater?= <clg@kaod.org>
Message-ID: <6d12f317-73bd-7152-d43d-23a49f3dcde5@kaod.org>
Date: Tue, 25 Apr 2017 16:32:14 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101
 Thunderbird/45.8.0
MIME-Version: 1.0
In-Reply-To: <79e166e2-ed4b-7386-c07f-b02d68f133b5@kaod.org>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 8bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1510
Lines: 39

On 04/25/2017 04:28 PM, Cédric Le Goater wrote:
> On 04/22/2017 08:11 AM, Michael Ellerman wrote:
>> Shilpasri G Bhat <shilpa.bhat@linux.vnet.ibm.com> writes:
>>> On 04/21/2017 05:17 PM, Cédric Le Goater wrote:
>>>> On 04/21/2017 06:31 AM, Shilpasri G Bhat wrote:
>>>>> diff --git a/drivers/hwmon/ibmpowernv.c b/drivers/hwmon/ibmpowernv.c
>>>>> index 6d2e660..1f329fa8 100644
>>>>> --- a/drivers/hwmon/ibmpowernv.c
>>>>> +++ b/drivers/hwmon/ibmpowernv.c
>>>>> @@ -65,7 +66,8 @@ enum sensors {
>>>>>  	{"fan", "ibm,opal-sensor-cooling-fan"},
>>>>>  	{"temp", "ibm,opal-sensor-amb-temp"},
>>>>>  	{"in", "ibm,opal-sensor-power-supply"},
>>>>> -	{"power", "ibm,opal-sensor-power"}
>>>>> +	{"power", "ibm,opal-sensor-power"},
>>>>> +	{"curr"}, /* Follows newer device tree compatible ibm,opal-sensor */
>>>>
>>>> why isn't there a compatible string ? 
>>>
>>> Skiboot exports "ibm,opal-sensor" as compatible string for all the inband
>>> sensors. Now if I define that as the compatible string here, then all the
>>> sensors would get identified as "curr" type of sensor by the driver.
>>
>> So fix it in skiboot?
> 
> 
> After a memory refresh, this table is to maintain compatibility with 
> the support of the FSP sensors in old firmware. These have peculiar
> device node names and properties.  
> 
> So What the code is doing looks correct. But, you should also modify 
> the 'enum sensors' to include a CURRENT value.

But the patch does that already. I was missing context. This is fine
then.

Thanks,

C.