Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1951173AbdDYPxn (ORCPT ); Tue, 25 Apr 2017 11:53:43 -0400 Received: from mezzanine.sirena.org.uk ([106.187.55.193]:33846 "EHLO mezzanine.sirena.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1951147AbdDYPxW (ORCPT ); Tue, 25 Apr 2017 11:53:22 -0400 Date: Tue, 25 Apr 2017 16:52:57 +0100 From: Mark Brown To: Richard Fitzgerald Cc: lee.jones@linaro.org, linus.walleij@linaro.org, gnurou@gmail.com, robh+dt@kernel.org, tglx@linutronix.de, jason@lakedaemon.net, alsa-devel@alsa-project.org, patches@opensource.wolfsonmicro.com, linux-gpio@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Message-ID: <20170425155257.s6m4wgrzxxsxcggo@sirena.org.uk> References: <1493050124-5970-1-git-send-email-rf@opensource.wolfsonmicro.com> <1493050124-5970-16-git-send-email-rf@opensource.wolfsonmicro.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="ibw4kwd45lk3fi6z" Content-Disposition: inline In-Reply-To: <1493050124-5970-16-git-send-email-rf@opensource.wolfsonmicro.com> X-Cookie: panic: can't find / User-Agent: NeoMutt/20170306 (1.8.0) X-SA-Exim-Connect-IP: 2001:470:1f1d:6b5::3 X-SA-Exim-Mail-From: broonie@sirena.org.uk Subject: Re: [PATCH v2 15/18] dt-bindings: sound: Add bindings for Cirrus Logic Madera codecs X-SA-Exim-Version: 4.2.1 (built Mon, 26 Dec 2011 16:24:06 +0000) X-SA-Exim-Scanned: No (on mezzanine.sirena.org.uk); Unknown failure Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1775 Lines: 45 --ibw4kwd45lk3fi6z Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Mon, Apr 24, 2017 at 05:08:41PM +0100, Richard Fitzgerald wrote: > The Cirrus Logic Madera codecs are a family of related codecs with > extensive digital and analogue I/O, digital mixing and routing, > signal processing and programmable DSPs. Please submit patches using subject lines reflecting the style for the subsystem. This makes it easier for people to identify relevant patches. Look at what existing commits in the area you're changing are doing and make sure your subject lines visually resemble what they're doing. > +Required properties: > + - compatible : One of the following chip-specific strings: > + "cirrus,cs47l35-codec" > + "cirrus,cs47l85-codec" > + "cirrus,cs47l90-codec" You shouldn't have compatible strings for subfunctions of a MFD unless these represent meaningful reusable IPs that can exist separately from the parent chip, that's clearly not the case here. All you're doing here is encoding Linux internal abstractions which aren't OS neutral and might change in future (for example clocking might move more into the clock API). --ibw4kwd45lk3fi6z Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCAAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAlj/cNgACgkQJNaLcl1U h9Dzfwf+K9DALVBhWKgWTELVOedgczqAhddAEMswkyTtko8j5t2ZIdDu2s42nKWn EGJzJVAAPzZanHlcbA51HXQsE/NK7PtzSrED3AVvGd3EiTGJ4m6IsXiGJyh5xxLU VYiD+FNlaBYPbD+HuBtoBTxPobWWzj09iOQtiGRvO0Z72ddh5/3oN5S0+61QKCHA UZh46HbqNzPa5cIbfb/FQygzgfazOyo4z1piaZ1MDE+Y/2sscK1xlkwV78mGASjc 4F7sKb0K31Hl/UbzTqVTIZwfysDlCgz207/I4Z/OdA+APj3wzYTnyGgjtpwNFBt3 vh3qCGLZGl+Wj02NxgX9WJDli/PUwA== =BHG7 -----END PGP SIGNATURE----- --ibw4kwd45lk3fi6z--