Message-ID: <1493137664.4826.75.camel@rf-debian.wolfsonmicro.main>
Subject: Re: [PATCH v2 15/18] dt-bindings: sound: Add bindings for Cirrus
 Logic Madera codecs
From: Richard Fitzgerald <rf@opensource.wolfsonmicro.com>
To: Mark Brown <broonie@kernel.org>
CC: <lee.jones@linaro.org>, <linus.walleij@linaro.org>, <gnurou@gmail.com>,
        <robh+dt@kernel.org>, <tglx@linutronix.de>, <jason@lakedaemon.net>,
        <alsa-devel@alsa-project.org>, <patches@opensource.wolfsonmicro.com>,
        <linux-gpio@vger.kernel.org>, <devicetree@vger.kernel.org>,
        <linux-kernel@vger.kernel.org>
Date: Tue, 25 Apr 2017 17:27:44 +0100
In-Reply-To: <20170425155257.s6m4wgrzxxsxcggo@sirena.org.uk>
References: <1493050124-5970-1-git-send-email-rf@opensource.wolfsonmicro.com>
         <1493050124-5970-16-git-send-email-rf@opensource.wolfsonmicro.com>
         <20170425155257.s6m4wgrzxxsxcggo@sirena.org.uk>
Content-Type: text/plain; charset="us-ascii"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1338
Lines: 28

On Tue, 2017-04-25 at 16:52 +0100, Mark Brown wrote:
> On Mon, Apr 24, 2017 at 05:08:41PM +0100, Richard Fitzgerald wrote:
> > The Cirrus Logic Madera codecs are a family of related codecs with
> > extensive digital and analogue I/O, digital mixing and routing,
> > signal processing and programmable DSPs.
> 
> Please submit patches using subject lines reflecting the style for the
> subsystem.  This makes it easier for people to identify relevant
> patches.  Look at what existing commits in the area you're changing are
> doing and make sure your subject lines visually resemble what they're
> doing.
> 
> > +Required properties:
> > +  - compatible : One of the following chip-specific strings:
> > +        "cirrus,cs47l35-codec"
> > +        "cirrus,cs47l85-codec"
> > +        "cirrus,cs47l90-codec"
> 
> You shouldn't have compatible strings for subfunctions of a MFD unless
> these represent meaningful reusable IPs that can exist separately from
> the parent chip, that's clearly not the case here.  All you're doing
> here is encoding Linux internal abstractions which aren't OS neutral and
> might change in future (for example clocking might move more into the
> clock API).

While that's nice, the of_node doesn't get populated if there isn't a
compatible string. And people don't like workarounds for the missing
of_node.