Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1952026AbdDYRXm (ORCPT ); Tue, 25 Apr 2017 13:23:42 -0400 Received: from mail-by2nam01on0052.outbound.protection.outlook.com ([104.47.34.52]:47771 "EHLO NAM01-BY2-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1952010AbdDYRXd (ORCPT ); Tue, 25 Apr 2017 13:23:33 -0400 Authentication-Results: spf=fail (sender IP is 192.88.168.50) smtp.mailfrom=nxp.com; googlemail.com; dkim=none (message not signed) header.d=none;googlemail.com; dmarc=fail action=none header.from=nxp.com; Message-ID: <1493141004.3557.8.camel@nxp.com> Subject: Re: [PATCH] ARM: dts: imx6sx-sdb: Remove cpufreq OPP override From: Leonard Crestez To: Fabio Estevam , Marek Vasut CC: Shawn Guo , Sascha Hauer , Peter Chen , Anson Huang , "linux-pm@vger.kernel.org" , Viresh Kumar , "Rafael J. Wysocki" , linux-kernel , Fabio Estevam , "linux-arm-kernel@lists.infradead.org" , Christoph Fritz Date: Tue, 25 Apr 2017 20:23:24 +0300 In-Reply-To: References: <89cc7192100bdc9ce546bf6000446e629457ebc1.1493138693.git.leonard.crestez@nxp.com> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.18.5.2-0ubuntu3.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-EOPAttributedMessage: 0 X-Matching-Connectors: 131376146096233674;(91ab9b29-cfa4-454e-5278-08d120cd25b8);() X-Forefront-Antispam-Report: CIP:192.88.168.50;IPV:NLI;CTRY:US;EFV:NLI;SFV:NSPM;SFS:(10009020)(6009001)(336005)(39380400002)(39850400002)(39400400002)(39410400002)(39840400002)(39860400002)(39450400003)(2980300002)(1109001)(1110001)(339900001)(377424004)(377454003)(199003)(52314003)(501694002)(189002)(24454002)(9170700003)(104016004)(4326008)(23676002)(76176999)(38730400002)(2950100002)(86362001)(305945005)(50986999)(6246003)(966004)(39060400002)(103116003)(5660300001)(7416002)(53546009)(356003)(50466002)(47776003)(36756003)(5820100001)(2870700001)(189998001)(85426001)(2906002)(50226002)(8936002)(54906002)(8656002)(6306002)(77096006)(33646002)(106466001)(53936002)(8676002)(229853002)(81166006)(105606002)(99106002)(32563001);DIR:OUT;SFP:1101;SCL:1;SRVR:CY1PR0301MB1195;H:tx30smr01.am.freescale.net;FPR:;SPF:Fail;MLV:ovrnspm;A:1;MX:1;PTR:InfoDomainNonexistent;LANG:en; X-Microsoft-Exchange-Diagnostics: 1;BN1BFFO11FD028;1:uz7HnQYWa/KqRSQBy+Upp+S6CycEa7yQE9SRDRres9+Qzm3FlWvehp5gdsVX8iS5erBkWC8NsK4bSFiLBRUJjelscLZ06oSo1KJ3bjX7BQX6XhGRv93t5Gk87w+FOtdOxTCE8zRCiq+eHK1Hay24it3rNEMPRLTVKxPywEd//U//6f3WqLzktlYSXXEY3JNkI1VNM7p7OGgJ/YN2TB70bttC73MKN2Bwn5CIu8VnNS3nvcxubjPUhYvL0npefzQrYcCNpPVn3Upd0uk2uDIgFX0+3jWICw4YHxCLnxIhHXdSka49Z3is2jveGWPvrfe/AO3jK5xxNT0tJSrpuVkaNuARXFUos6tGizYxmPTIeEDnmXG7oUIfWkw+pgk2K/mZ3NtneuedTS5Yblo/AYQGVrvlsrwl6VNcO+E+ypSDQL0E9WaRu9YOCZf4Sdg++KEnW3nwjaHyjNhZb7Iroe+3ZFYFVMA3h8utoPMbUac2fChgKupmjLjFNTuz1p+ENEHBeN7C+Ei0zvKDTU/dbkU1ofdv2fmkG1qMe9rCxY9vkvWHDS5UO+lKaMwYoNaV5tJjwzSXkQ+heYuoipSwQx1RNoUTKuSwehlHiouV4RKoeleIBB9QEVSgQ+VzKOBd6HSTCZkK6YBwoCSXB3lFy9IE6g== X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: d23f6107-2c45-406c-3b6a-08d48bffca7b X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:(22001)(201703131430075)(201703131517081);SRVR:CY1PR0301MB1195; X-Microsoft-Exchange-Diagnostics: 1;CY1PR0301MB1195;3:N9aBtUm9CXzLWQwFjTnwl/3kgOtzp0ASoXq0ZRzN9zrccDYBMdGNsHSTiHukDvjdhB4uqn4niy5/+2QRW3d2OiYyihCHGlUUbKY5/alIICygY1PgOoZrTojGqWosCsukuJ8dKZ9twK5q1nkmdIqQYRKP1/pUl/HOcTFvZPaouiBCmkDBiAQsj2E4aVA9oITj+rqWAKoWofJO5JG3oFr+ohaqo+tCkk8cfU0LrzAW4pchNn4hj8U98BJquqDCbPAPlJ8qvYWWFgH1SuuJsg9TAN4DyakilHCKaTdjK4mgLmFOdVK3EPCw1cs28labYRYRrSQdpd2XXwl8H4WEyvH5jtEczEh2i0eMXofDbgl/WH5D8i2N5DSu+mz3YrEFsYUoQiuMnY2l+HSRgDtxFL2fNuqdeHMng+JW3IKwZtQ4/NmXTep5QhhuRgbo7UGx0nAZ;25:KjXVlXTgenWg+y/IaqqDbNI+ieQuJiATvggC2+XmjbR1fE6SgabxERpR/KpDezP5P/0vYXvCBEdNoSN+4Q8BLdC7hWwUA8NY/tPCaBVOvhtw282fQhUbeD8gc6J7e6AXfHPLmWqMVguVpcBXR5DH9b5IGIaqu5/p029oQr5h024mO7H9kzbHb+8FqvwI9hsoC++1KMpqodpa3uNVvh8J6Bjraabh18+VgXT2hseVljwknq+3l9fLqYPau6ujhGRhU23GzZP/dCwjzYiGUMuACptsmDTvitvWDCkwg0GmLGCOQdsKnISEuB7/XiC5bBEagmJetv7lzpWSz7AbDXkzoZkITt3Gya2hraHtNdKE0Kfq/eGaOX4G1TQjylYx3cANR0GNLJZGFeuEysLf7txO07PZYLPlLPBnuBrNpFXfM21d+4knIPH/7Ttv+zZofnoF4/1iWT6AWPldxyegIXRHrA== X-Microsoft-Exchange-Diagnostics: 1;CY1PR0301MB1195;31:j0umm650w+qflRhQoIYzgQcgruAlelnW8DVUvI26qVGwqj054tpRXaLSBvq3cRySbrtpREIPfZ8ynVJWWtLEf0RgP0VT5g3IldRcPRkq3bSCvLnrEGhdY51JK7SJRmbsSDZXND9WCDmiiI0P4lobjtYmqXuysWkTjTsGbVbo6dk9phAzLhblRfcn+sAvoI5a6hy1pDtMVNWKcErMFnW29svjxNt6Paqc+lfcLp3ZRlpmoaieMFaPRPJaCFasm64mAwORnR0e36G7cTdbYTjUfQ== X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(185117386973197)(258649278758335); X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(6095135)(601004)(2401047)(13017025)(5005006)(13015025)(8121501046)(13023025)(13018025)(13024025)(3002001)(10201501046)(93006095)(93001095)(6055026)(6096035)(20161123565025)(20161123556025)(20161123561025)(201703131430075)(201703131433075)(201703131441075)(201703131448075)(201703161259150)(20161123563025);SRVR:CY1PR0301MB1195;BCL:0;PCL:0;RULEID:(400006);SRVR:CY1PR0301MB1195; X-Microsoft-Exchange-Diagnostics: =?utf-8?B?MTtDWTFQUjAzMDFNQjExOTU7NDpvSVNiTXVZbVgvaGVBdHVoZlBzVUVuU1B1?= =?utf-8?B?blpyeGZMTTNQV3JMY2poTnNDM005c29wN2xwemZybHJ6WVpVUkY0MmpiQUdJ?= =?utf-8?B?Q29ydkl6d2YyY3pJMytXcUhqUFhqQi8wUEMxN2lKeEhmeUNGK1hDdWhxdjVm?= =?utf-8?B?WHBHS09SUWIrTWtlNjNBenc4V0xSeVdEZGUvMGtMcFVLNVN6NHN2Q2k3cGhj?= =?utf-8?B?dGNDbHdZOFRlQmNqcVBBdi8veE83SGY0REtvMXlVYXFUcjNvTzlGTHBJQWMr?= =?utf-8?B?bTZkUWVDMm5rNGdyWEYySzZUMFc4czg2NDBIclh3YzdGeTdJRUprSWthdW04?= =?utf-8?B?Z1hUbWVGUW5tVEliaDQveDdSSXMrSmVXV0lSbzV3NmFtWm8xT2I2bjM3TzJB?= =?utf-8?B?aFJMaE9FNXVGVmErOU5xWWtSc1U5UkJCbFB4QTRtNlB5TFRaS3cvZDJQN21q?= =?utf-8?B?V0FPNm1Ca092bStSNDlpbFVzczhKUVFOZmp3ZDcrT1V3dlA4c1J2K2FZbnE2?= =?utf-8?B?ak90ZmVGL2kxckp1YnFGb0dhZWtqejFHMjVTdnU3WDZZNjBzLzlScXROdGVi?= =?utf-8?B?SXNZSmxET2k5eml4dTJGWHh1K3JqMU8wVFFVNnBWTjB0Zk1ZdWRSSmpYY3BO?= =?utf-8?B?a2JXT0RKMlNhemNVL3pUcFJHZlRoMWN0Tk9mb1kvbUJoeTJQcENPeEx5bkFU?= =?utf-8?B?VHVrWVZUUW4zSnRMUnNOSy94UEY4ZTM5QkNNc0hJRkxWclN0ZmlyWTYwWlV0?= =?utf-8?B?b21aUFlZVFNGUC9POEdFeFV6WnI5NEFrTURJN2FJTGFYREhNTWRPR3FkSm5i?= =?utf-8?B?elNTMDRLQk94clRPZHVoUTBmamdMTGlBa1JRZW9vY1pKdlNsVU4yMlVrWVBm?= =?utf-8?B?cEl5R3dRS2Z6WXZ6dlljWU5NcFYzQXd6THJvMWhjdWJIS0I3NEFjZ05UbERI?= =?utf-8?B?ZjNJMGpGOXQ1WTRLRjNTMmZuZFZTUkF0bFNnUktVUkY0VHpVZy9vcXVYUTRX?= =?utf-8?B?ZVhWMEZjTUlVYW9pVmEvVzJpY3o4STNibkxXYk94S3VubFk0UEVvZ1krZFhv?= =?utf-8?B?Mll2c3k0RDZtNXlBUis5QlRRZ25zYzdIVHZUUVRvbEpTc1JzUXZRUGlRRm1D?= =?utf-8?B?d2NibVR4ZHR1aE5wbW9jRXllelg2bmhmNnRKMVVMNTBmb1g1VXo5cnE5UU5m?= =?utf-8?B?S2lYZmYxUS93RU1vVGg5SG1FOXZ5cU5FSm1kdnRXd01seGVnWlliaGl1eWpC?= =?utf-8?B?Z2ZFN21sSytQa2ViYmtoeDFXOGNGeC84SWhBRWd2eGVld21vNFBIZUNNd3Yw?= =?utf-8?B?Qk0zYkt0dmpoemJBPT0=?= X-Forefront-PRVS: 0288CD37D9 X-Microsoft-Exchange-Diagnostics: =?utf-8?B?MTtDWTFQUjAzMDFNQjExOTU7MjM6U254ZWQyZ09MRHVMRXZFT0tMYlpEYW4r?= =?utf-8?B?V0dvcGdHWU45UXQrcThZdHc0bkxOekdGMGlERjg4MHFtakFMbmRDaXB2Szdu?= =?utf-8?B?SURhWkRoOGFOVE92dVMva2xHaC9NTmRkQllUemprL0lZWDlhL1E0WldNUEZV?= =?utf-8?B?RWdIbzdyV1RwYlBUMzNLY01qS1ZhaWx2aVFXdzlhTmlzNGNYVE5SMFpDOUF4?= =?utf-8?B?Ykh4MmgyNDhJR2xlaGQya0pSSXVmWkVRUXNCMU1XMi9zWWtkZXcwbkYrb3hn?= =?utf-8?B?VVhhbWYrVzc1ZFN4Y0oyRGtGV01IMHJYOTduTld2YUhvR3pOODZxaWtuSUtQ?= =?utf-8?B?RTAxZm5BTG0wYm8xUEhWN3d4dDBYcDFSNlVwb3NNa3dhY05hMisxWlIrZXVw?= =?utf-8?B?L1c4aGptamZ4ZUt4YWh1WmR6YXlkZ05xVFFHOW1KZlgyNDFzRHBzK3VKcHk5?= =?utf-8?B?b3ZQSGFGdGV6Y1E2MnhlUENiL045VDQ2Z3lZT1NlQW0zR2xSOHpUanZRd3hZ?= =?utf-8?B?NTZRMkxXcVNLQ3VNWEZoRFQzZ2JMY1d2a0NES2NGQnQwdUhZeTBFZ00zUk9V?= =?utf-8?B?UmhleXJOOWQ1YzhNbE1EbklsTmVVTVZXczY3WG5JdURCaENHd3hsTnBXUk5W?= =?utf-8?B?ZlJZcEIreitjeWpRWWxLd3RDTlFKeERWOUQzSGFHNmNkN3psMTlhVTQ5L3Yv?= =?utf-8?B?S0tISTRpMndQOFQvNVlMRXMzK2dOejdGbURXamJScWIrazRvZUhweDhnUlJv?= =?utf-8?B?b2huMUltMXJwS2NUb1U3NURyZTlWWmh0ZUQwbm5lVFM3ditWR1AxTXdCeWdQ?= =?utf-8?B?R3l1eVlKbDJDU3Q1eUNWK2loa2NkcVZYd3hkMmJwTVByLytFTGRZS2hmSmJ2?= =?utf-8?B?ZEVkdUF2NTFPbGU5WEhQaG9ROHVhMzZqRWVEU0tQYmZYUVc3U2FqREUzYnd5?= =?utf-8?B?clk4UnA1b3hUdWQ1ejhSZTViU3BRSi9XcHQyTHZJVGJsNVZsZ2lxVFB5MGxQ?= =?utf-8?B?czVORS9jKzNZLzQ5UVdEbDVCRVpXZjlYWjVxMmszRkxRWTJqTDN1dzkxUU5I?= =?utf-8?B?NTlHMjhPUGQ0dTZrYlladVVCVEVUT3hDV2NKRTB3bDU0MW5wTHNzTUxGRVdv?= =?utf-8?B?UlQzNVNQUUE2TUVJS2RNVXJzM2pyVmNjVzd1b1liY1pibzhuTFRMa2t5dG5y?= =?utf-8?B?NklqQVZVeEVEc3FJdFdhb0dRTXh5YWEvelJGOC96dGxEcGQxcFc5Y2NiT0ll?= =?utf-8?B?aDRxYU41UElyU0VLWDJhSFBzNWxUWTJNRXhKbXhWaktLV003eVdZZHZnSy9P?= =?utf-8?B?bWZ4VTZLR1hjNzVheWRlZkN1cmtaVk5CbXNBeGo5c21zcHdUb2FQUVVGdlZ2?= =?utf-8?B?Sk5lTlpjNkVMMzBxTk1vVEc0OGx2SU1LYnJpQlA4RFZ3eFdOQ3MyRzMxL2N3?= =?utf-8?B?N1A1L0xNcDlOYW1pSTdRSmt1dVJPUWhaRzFrOGRvM3VtU25nYy9ENVJVbVZM?= =?utf-8?B?UHIwMm5NNjVIM3NjbnZYMjFqeDNCeW84eWpWeDdzdjNpeVlvTGJyakYwK2Zo?= =?utf-8?B?RFhCbjZ2N1NwcDZLUEJ0ZXoyRjdTUHlaK1BLRkc4Z2czVlNJbWRDdnVwajZZ?= =?utf-8?B?S0ZXL3h4WS83Y28vUjJlaGRVcGliYkU4Sm9QRmJKMGxGajl3Y1J6SWVYZWVz?= =?utf-8?B?YWpXazBOSUpnMFRhR2NlQStqbmdKeWhzTXlSV2VvTTBlQUswTW0rNHJpcnEw?= =?utf-8?B?cUVXTk5nbjkwR1VXZHBCNmlHd2k5WlpRUzA0SE9oQ1pYRHhlbUZhVmJWZkNo?= =?utf-8?B?RkpDVWpwMWQzWXBjRGJMK24zTjVudGlnZE9HRnh2ZkhDeUtyODZxczA4WkdY?= =?utf-8?B?SEFhalRwTGRCWDBkN3RzZ2hadmUxemNnQTk2NVBkbzFkbjh2dUhra1I1Z0lN?= =?utf-8?B?NHFyalpIWVVpK3B3NjZrZlFiZ1JGTlZiSGJMZkFERzVrNU56ZFdlYkhOeWl0?= =?utf-8?B?ckxGOU0xNkkxMXBwVkNrOVY4Rk1DbHJVMDJ0WWNnPT0=?= X-Microsoft-Exchange-Diagnostics: 1;CY1PR0301MB1195;6:1SdPeE1hlFYD85eUdTSMs/OD3s6N3yeLDCviLysP23KV2Og9bw62QTAes6zogeMpCthFQ3PAACnwqEQbLrehg/OwRt79OxQoaHWxhgYcyW/xiJENtFAwdydZMkz0Uimpei7h/+9ORbW0ACCktKImnLKmYoYqKukPpj2HUMuC1BVAiqC1Xlm+Bt5IwQtCKi+5NprbwmpZJHZqKrE/nRMhpUsuyj55pm1tuu7C3PCLa9QCc4jXyqHwW0qiAzFhVXCk8KP6Gba99iKZ+zI8s84798k2hpwOre9/MmNfRh/qV8Ncy12xR8ps7EMFN9+x5t0Kcf+uiaGAbMwcyQQDFLvBG/Jsrn/nqTjk30MVzO8UtdYbUtc5hCNKWdRA6N5kjgkOIxYnVQmq3BahEvtU1p2XaKUfAaaBzfVsCXv3Q8LPui/nDWI03/038XSZ7PS7pJGvSXNrj+4+VShj1MF7cjO8YgmbYjmNVSPqwjqQfMTsV9/3yQ/rWYe0u4HYC9GUQ8vm;5:CCYJNsIjWyDxiPgh91lRtuhhQ8LYe+ju0qAJB9NVuBTJ8lVNETO5ZZY1xI4zjijAu3VjC16kACg3jf2xhJZYWKVIR7tqZBS92d9+MhuxQea+YMlY9Cw1pRlTRvoP1uF9IHW9doLKytz17lqaYQwD31AnL+D+DBPepfTbocr7XF/HTSPGNnZIJWikTJb1Usjy;24:mWy2dQdSsB2fAY8P9ouq/a1NL3WPebsRvUmHXI1IWeinPcPE+DWKhrxxn95sxbvZ7yb0QJEL4dgmU1jssh8BnzW0kSZsoafwojIYYH1glhw= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1;CY1PR0301MB1195;7:CoJpDLl9ZY71iaIxZZdHDLYgbmwZCR79rq7wGkeQn3KSnb/EEOSpy7zllXh8jvLKhjFzI9osPMy1YqamgaXxPPxOVAzJn/j/MhFyKrsGqZi89p3JDkeZ3tIFkzJsxlip7lQFL+GpyCfWWYFu6BX1JDRYb0d2zwMAh6lk6B87iDdxoXEjTEakpKW4RZ0HxwO9higaM9q9guueLyA3h1fxIbeViKB+L1YI/n6MHM2X5BOMcSVAlXxJQeDtgegXMDO9O7X8S08py51Er3gcfSOX37/v0W42vQ1PopKxDDolCYeutRyn/78y9iSFvO90fTTCs2BBNn+00dMQz3MJEbzDbw== X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 Apr 2017 17:23:29.2957 (UTC) X-MS-Exchange-CrossTenant-Id: 5afe0b00-7697-4969-b663-5eab37d5f47e X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=5afe0b00-7697-4969-b663-5eab37d5f47e;Ip=[192.88.168.50];Helo=[tx30smr01.am.freescale.net] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY1PR0301MB1195 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2127 Lines: 51 On Tue, 2017-04-25 at 14:02 -0300, Fabio Estevam wrote: > On Tue, Apr 25, 2017 at 2:02 PM, Fabio Estevam wrote: > > > > Hi Leonard, > > > > On Tue, Apr 25, 2017 at 1:57 PM, Leonard Crestez > > wrote: > > > > > > The board file for imx6sx-dbg overrides cpufreq operating points to use > > > higher voltages. This is done because the board has a shared rail for > > > VDD_ARM_IN and VDD_SOC_IN and when using LDO bypass the shared voltage > > > needs to be a value suitable for both ARM and SOC. > > > > > > This was introduced in: > > > > > > commit 54183bd7f766 ("ARM: imx6sx-sdb: add revb board and make it default") > > > > > > This only only applies to LDO bypass mode, a feature not present in > > > upstream. When LDOs are enabled the effect is to use higher voltages than > > > necesarry for no good reason. > > > > > > Setting these higher voltages can make some boards fail to boot with ugly > > > semi-random crashes, reminiscent of memory corruption. These failures > > > happen the first time the lowest idle state is used. Remove the OPP > > > override in order to fix those crashes. > > > > > > Signed-off-by: Leonard Crestez > > > > > > --- > > > It's not clear exactly why the crashes happen. Perhaps waking up from idle > > > draws more power than is available? Removing this override is a correct > > > change anyway so maybe there is no need to investigate deeper. > > Marek just sent a similar one a few minutes ago: > > http://lists.infradead.org/pipermail/linux-arm-kernel/2017-April/503230.html > Forgot to add Marek. Wow, that was literally 15 minutes before my patch. In my defense I did search the archives before starting to format the patch but it had not arrived yet. Anyway, that version also sets the supply for reg_arm and reg_soc. It is not necessary for fixing the crash I'm seeing but is good because it will result in the minimum voltage on VDD_ARM_SOC_IN rather than a fix 1375mv. I tested Marek's patch and it works fine on my rev B board (which otherwise fails to boot upstream). --  Regards, Leonard