Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1953474AbdDYSff (ORCPT ); Tue, 25 Apr 2017 14:35:35 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:41244 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1950961AbdDYSf1 (ORCPT ); Tue, 25 Apr 2017 14:35:27 -0400 Date: Tue, 25 Apr 2017 20:35:18 +0200 From: Greg Kroah-Hartman To: Fabian Frederick Cc: Mauro Carvalho Chehab , Alan Cox , linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/1 linux-next] staging: media: atomisp: kmap() can't fail Message-ID: <20170425183518.GB8827@kroah.com> References: <20170425181019.1655-1-fabf@skynet.be> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170425181019.1655-1-fabf@skynet.be> User-Agent: Mutt/1.8.2 (2017-04-18) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 281 Lines: 10 On Tue, Apr 25, 2017 at 08:10:19PM +0200, Fabian Frederick wrote: > Remove NULL test on kmap() That says _what_ you did, which is obvious if you read the patch. You need to say _why_ you are doing what you are doing in this patch in the changelog description. thanks, greg k-h