Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1953937AbdDYUJU (ORCPT ); Tue, 25 Apr 2017 16:09:20 -0400 Received: from mail.free-electrons.com ([62.4.15.54]:60421 "EHLO mail.free-electrons.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1949185AbdDYUJN (ORCPT ); Tue, 25 Apr 2017 16:09:13 -0400 Date: Tue, 25 Apr 2017 22:09:11 +0200 From: Alexandre Belloni To: Alexander Kochetkov Cc: David Miller , Florian Fainelli , netdev@vger.kernel.org, LKML , Sergei Shtylyov , Roger Quadros , Madalin Bucur Subject: Re: [PATCH v1] net: phy: fix auto-negotiation stall due to unavailable interrupt Message-ID: <20170425200911.d7zfakqs5k5zwisg@piout.net> References: <1492686004-30527-1-git-send-email-al.kochet@gmail.com> <1492686004-30527-2-git-send-email-al.kochet@gmail.com> <20170425.103644.75674234677063517.davem@davemloft.net> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: NeoMutt/20170113 (1.7.2) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1261 Lines: 37 Hi, On 25/04/2017 at 18:25:30 +0300, Alexander Kochetkov wrote: > Hello David! > > > 25 апр. 2017 г., в 17:36, David Miller написал(а): > > > > So... what are we doing here? > > > > My understanding is that this should fix the same problem that commit > > 99f81afc139c6edd14d77a91ee91685a414a1c66 ("phy: micrel: Disable auto > > negotiation on startup") fixed and that this micrel commit should thus > > be reverted to improve MAC startup times which regressed. > > > > Florian, any guidance? > > Yes, this should be done. > > I aksed Alexandre to check if 99f81afc139c6edd14d77a91ee91685a414a1c66 ("phy: micrel: Disable auto > negotiation on startup») can be reverted, and he answered what it may do that > sometime this/next week. > Yes, it can be safely reverted after Alexander's patch. I had to test on v4.7 because we are not using interrupts on those boards since v4.8 (another issue to be fixed). As Florian pointed out, at the time I sent my patch, I didn't have time to investigate whether this was affecting other phys, see https://lkml.org/lkml/2016/2/26/766 I can send the revert or you can do it. -- Alexandre Belloni, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com