Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1954203AbdDYU1A (ORCPT ); Tue, 25 Apr 2017 16:27:00 -0400 Received: from shards.monkeyblade.net ([184.105.139.130]:44888 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1949636AbdDYU0s (ORCPT ); Tue, 25 Apr 2017 16:26:48 -0400 Date: Tue, 25 Apr 2017 16:26:25 -0400 (EDT) Message-Id: <20170425.162625.941066354018174414.davem@davemloft.net> To: alexandre.belloni@free-electrons.com Cc: al.kochet@gmail.com, f.fainelli@gmail.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, sergei.shtylyov@cogentembedded.com, rogerq@ti.com, madalin.bucur@nxp.com Subject: Re: [PATCH v1] net: phy: fix auto-negotiation stall due to unavailable interrupt From: David Miller In-Reply-To: <20170425200911.d7zfakqs5k5zwisg@piout.net> References: <20170425.103644.75674234677063517.davem@davemloft.net> <20170425200911.d7zfakqs5k5zwisg@piout.net> X-Mailer: Mew version 6.7 on Emacs 25.1 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=utf-8 X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Tue, 25 Apr 2017 12:45:03 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from base64 to 8bit by mail.home.local id v3PKR6lJ021267 Content-Length: 1349 Lines: 37 From: Alexandre Belloni Date: Tue, 25 Apr 2017 22:09:11 +0200 > Hi, > > On 25/04/2017 at 18:25:30 +0300, Alexander Kochetkov wrote: >> Hello David! >> >> > 25 апр. 2017 г., в 17:36, David Miller написал(а): >> > >> > So... what are we doing here? >> > >> > My understanding is that this should fix the same problem that commit >> > 99f81afc139c6edd14d77a91ee91685a414a1c66 ("phy: micrel: Disable auto >> > negotiation on startup") fixed and that this micrel commit should thus >> > be reverted to improve MAC startup times which regressed. >> > >> > Florian, any guidance? >> >> Yes, this should be done. >> >> I aksed Alexandre to check if 99f81afc139c6edd14d77a91ee91685a414a1c66 ("phy: micrel: Disable auto >> negotiation on startup») can be reverted, and he answered what it may do that >> sometime this/next week. >> > > Yes, it can be safely reverted after Alexander's patch. I had to test on > v4.7 because we are not using interrupts on those boards since v4.8 > (another issue to be fixed). > > As Florian pointed out, at the time I sent my patch, I didn't have time > to investigate whether this was affecting other phys, see > https://lkml.org/lkml/2016/2/26/766 > > I can send the revert or you can do it. I can take care of it, thanks for testing.