Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2993643AbdDYVHx (ORCPT ); Tue, 25 Apr 2017 17:07:53 -0400 Received: from mail-qk0-f196.google.com ([209.85.220.196]:36276 "EHLO mail-qk0-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2993591AbdDYVHi (ORCPT ); Tue, 25 Apr 2017 17:07:38 -0400 Subject: Re: [PATCH v1] net: phy: fix auto-negotiation stall due to unavailable interrupt To: David Miller , alexandre.belloni@free-electrons.com References: <20170425.103644.75674234677063517.davem@davemloft.net> <20170425200911.d7zfakqs5k5zwisg@piout.net> <20170425.162625.941066354018174414.davem@davemloft.net> Cc: al.kochet@gmail.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, sergei.shtylyov@cogentembedded.com, rogerq@ti.com, madalin.bucur@nxp.com From: Florian Fainelli Message-ID: <56206647-5251-9387-b671-f84d6c6a0eb9@gmail.com> Date: Tue, 25 Apr 2017 14:07:28 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.8.0 MIME-Version: 1.0 In-Reply-To: <20170425.162625.941066354018174414.davem@davemloft.net> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1728 Lines: 49 On 04/25/2017 01:26 PM, David Miller wrote: > From: Alexandre Belloni > Date: Tue, 25 Apr 2017 22:09:11 +0200 > >> Hi, >> >> On 25/04/2017 at 18:25:30 +0300, Alexander Kochetkov wrote: >>> Hello David! >>> >>>> 25 апр. 2017 г., в 17:36, David Miller написал(а): >>>> >>>> So... what are we doing here? >>>> >>>> My understanding is that this should fix the same problem that commit >>>> 99f81afc139c6edd14d77a91ee91685a414a1c66 ("phy: micrel: Disable auto >>>> negotiation on startup") fixed and that this micrel commit should thus >>>> be reverted to improve MAC startup times which regressed. >>>> >>>> Florian, any guidance? >>> >>> Yes, this should be done. >>> >>> I aksed Alexandre to check if 99f81afc139c6edd14d77a91ee91685a414a1c66 ("phy: micrel: Disable auto >>> negotiation on startup») can be reverted, and he answered what it may do that >>> sometime this/next week. >>> >> >> Yes, it can be safely reverted after Alexander's patch. I had to test on >> v4.7 because we are not using interrupts on those boards since v4.8 >> (another issue to be fixed). >> >> As Florian pointed out, at the time I sent my patch, I didn't have time >> to investigate whether this was affecting other phys, see >> https://lkml.org/lkml/2016/2/26/766 >> >> I can send the revert or you can do it. > > I can take care of it, thanks for testing. Thanks! Can you add the following Fixes tag: Fixes: 321beec5047a (net: phy: Use interrupts when available in NOLINK state) BTW, can you have the netdev patchwork instance automatically accepted Fixes: tag sent as replies to patches? (just like Acked-by, Reviewed-by and so on are already accepted)? -- Florian