From: "Kani, Toshimitsu" <toshi.kani@hpe.com>
To: "vishal.l.verma@intel.com" <vishal.l.verma@intel.com>
CC: "dan.j.williams@intel.com" <dan.j.williams@intel.com>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "dave.jiang@intel.com" <dave.jiang@intel.com>,
        "linux-nvdimm@lists.01.org" <linux-nvdimm@ml01.01.org>
Subject: Re: [PATCH] libnvdimm: fix phys_addr for nvdimm_clear_poison
Thread-Topic: [PATCH] libnvdimm: fix phys_addr for nvdimm_clear_poison
Thread-Index: AQHSvgllyy/bJS1QM0+dvaerPKR3/6HWniAAgAABYQA=
Date: Tue, 25 Apr 2017 21:49:50 +0000
Message-ID: <1493156958.26622.8.camel@hpe.com>
References: <20170425211651.7640-1-toshi.kani@hpe.com>
         <20170425214422.GB15722@omniknight.lm.intel.com>
In-Reply-To: <20170425214422.GB15722@omniknight.lm.intel.com>
Accept-Language: en-US
Content-Language: en-US
spamdiagnosticoutput: 1:99
spamdiagnosticmetadata: NSPM
Content-Type: text/plain; charset="utf-8"
Content-ID: <1365CE7062905441BACC7666CC2782B2@NAMPRD84.PROD.OUTLOOK.COM>
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-originalarrivaltime: 25 Apr 2017 21:49:50.5862
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 105b2061-b669-4b31-92ac-24d304d195dc
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AT5PR84MB0257
X-OriginatorOrg: hpe.com
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Transfer-Encoding: 8bit
X-MIME-Autoconverted: from base64 to 8bit by mail.home.local id v3PLpQ77013121
Content-Length: 1335
Lines: 46

On Tue, 2017-04-25 at 15:44 -0600, Vishal Verma wrote:
> On 04/25, Toshi Kani wrote:
> > nvdimm_clear_poison() expects a physical address, not an offset.
> > Fix nsio_rw_bytes() to call nvdimm_clear_poison() with a physical
> > address.
> 
> Good catch!
> 
> > 
> > Signed-off-by: Toshi Kani <toshi.kani@hpe.com>
> > Cc: Dan Williams <dan.j.williams@intel.com>
> > Cc: Dave Jiang <dave.jiang@intel.com>
> > Cc: Vishal Verma <vishal.l.verma@intel.com>
> > ---
> >  drivers/nvdimm/claim.c |    3 ++-
> >  1 file changed, 2 insertions(+), 1 deletion(-)
> > 
> > diff --git a/drivers/nvdimm/claim.c b/drivers/nvdimm/claim.c
> > index ca6d572..0b31073 100644
> > --- a/drivers/nvdimm/claim.c
> > +++ b/drivers/nvdimm/claim.c
> > @@ -254,7 +254,8 @@ static int nsio_rw_bytes(struct
> > nd_namespace_common *ndns,
> >  				&& (!ndns->claim ||
> > !is_nd_btt(ndns->claim))) {
> >  			long cleared;
> >  
> > -			cleared = nvdimm_clear_poison(&ndns->dev,
> > offset, size);
> > +			cleared = nvdimm_clear_poison(&ndns->dev,
> > +					nsio->res.start + offset,
> > size);
> 
> Should we be using nsio->res.start here or nsio->addr ?

nsio->addr is a virtual address.  We need to pass the physical address
of this range.

Thanks,
-Toshi


> 
> >  			if (cleared < size)
> >  				rc = -EIO;
> >  			if (cleared > 0 && cleared / 512) {