Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1432596AbdDYWFO (ORCPT <rfc822;w@1wt.eu>);
        Tue, 25 Apr 2017 18:05:14 -0400
Received: from conssluserg-02.nifty.com ([210.131.2.81]:53827 "EHLO
        conssluserg-02.nifty.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1430741AbdDYWFH (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Tue, 25 Apr 2017 18:05:07 -0400
DKIM-Filter: OpenDKIM Filter v2.10.3 conssluserg-02.nifty.com v3PM4r7b019330
X-Nifty-SrcIP: [209.85.161.174]
MIME-Version: 1.0
In-Reply-To: <1493075119-32026-2-git-send-email-frowand.list@gmail.com>
References: <1493075119-32026-1-git-send-email-frowand.list@gmail.com> <1493075119-32026-2-git-send-email-frowand.list@gmail.com>
From: Masahiro Yamada <yamada.masahiro@socionext.com>
Date: Wed, 26 Apr 2017 07:04:52 +0900
X-Gmail-Original-Message-ID: <CAK7LNARd-XsCfSJhDj3JisH=u4XZm8DaPEa5Pg2ciWrq8Ueing@mail.gmail.com>
Message-ID: <CAK7LNARd-XsCfSJhDj3JisH=u4XZm8DaPEa5Pg2ciWrq8Ueing@mail.gmail.com>
Subject: Re: [PATCH v2 1/2] of: support dtc compiler flags for overlays
To: Frank Rowand <frowand.list@gmail.com>
Cc: Rob Herring <robh+dt@kernel.org>,
        Stephen Boyd <stephen.boyd@linaro.org>, Michal Marek <mmarek@suse.com>,
        devicetree@vger.kernel.org,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        Linux Kbuild mailing list <linux-kbuild@vger.kernel.org>
Content-Type: text/plain; charset=UTF-8
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 1165
Lines: 45

2017-04-25 8:05 GMT+09:00  <frowand.list@gmail.com>:
> From: Frank Rowand <frank.rowand@sony.com>
>
> The dtc compiler version that adds initial support was available
> in 4.11-rc1.  Add the ability to set the dtc compiler flags needed
> by overlays.
>
> Signed-off-by: Frank Rowand <frank.rowand@sony.com>
> ---


I know your motivation for 1/2 is overlay,
but this patch itself is more generic.
(support for per-file dtc compiler flag)

Could you reword the commit subject a little bit?

Otherwise,

Acked-by: Masahiro Yamada <yamada.masahiro@socionext.com>



>  scripts/Makefile.lib | 2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/scripts/Makefile.lib b/scripts/Makefile.lib
> index 0a07f9014944..0bbec480d323 100644
> --- a/scripts/Makefile.lib
> +++ b/scripts/Makefile.lib
> @@ -283,6 +283,8 @@ ifeq ($(KBUILD_ENABLE_EXTRA_GCC_CHECKS),)
>  DTC_FLAGS += -Wno-unit_address_vs_reg
>  endif
>
> +DTC_FLAGS += $(DTC_FLAGS_$(basetarget))
> +
>  # Generate an assembly file to wrap the output of the device tree compiler
>  quiet_cmd_dt_S_dtb= DTB     $@
>  cmd_dt_S_dtb=                                          \
> --


-- 
Best Regards
Masahiro Yamada