DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 3486561B8C
Date: Tue, 25 Apr 2017 19:32:07 -0700
From: Jessica Yu <jeyu@redhat.com>
To: Kees Cook <keescook@chromium.org>
Cc: Rusty Russell <rusty@rustcorp.com.au>,
        "Peter Zijlstra (Intel)" <peterz@infradead.org>,
        Josh Poimboeuf <jpoimboe@redhat.com>,
        Ard Biesheuvel <ard.biesheuvel@linaro.org>,
        Heinrich Schuchardt <xypron.glpk@gmx.de>,
        Nicholas Piggin <npiggin@gmail.com>,
        Chris Metcalf <cmetcalf@mellanox.com>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 0/2] module: Add module name to modinfo
Message-ID: <20170426023206.raeaeqylnnjo25on@jeyu>
References: <1492814127-66318-1-git-send-email-keescook@chromium.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii; format=flowed
Content-Disposition: inline
In-Reply-To: <1492814127-66318-1-git-send-email-keescook@chromium.org>
User-Agent: NeoMutt/20161126 (1.7.1)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 609
Lines: 20

+++ Kees Cook [21/04/17 15:35 -0700]:
>The mod structure is accessed for the "name" field prior to validating
>sanity in check_modstruct_version(). This becomes very obvious once
>struct layout randomization is happening, so instead add the module
>name to modinfo and use that until the mod struct has been sanity-checked.
>
>-Kees
>
>v2:
>- adjusted for more odd name load failure cases; jeyu

Hi Kees!

These patches look fine to me, would you mind if I held on to them
until after the upcoming merge window? (Since we're at -rc8, and I'd
still like for them to sit in -next for a while)

Thanks,

Jessica