Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1430745AbdDZC6Q (ORCPT ); Tue, 25 Apr 2017 22:58:16 -0400 Received: from mx1.redhat.com ([209.132.183.28]:47932 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1758527AbdDZC6F (ORCPT ); Tue, 25 Apr 2017 22:58:05 -0400 DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com CB68AC04B941 Authentication-Results: ext-mx07.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx07.extmail.prod.ext.phx2.redhat.com; spf=pass smtp.mailfrom=jeyu@redhat.com DKIM-Filter: OpenDKIM Filter v2.11.0 mx1.redhat.com CB68AC04B941 Date: Tue, 25 Apr 2017 19:58:02 -0700 From: Jessica Yu To: Jon Masters Cc: Kees Cook , Rusty Russell , "Peter Zijlstra (Intel)" , Josh Poimboeuf , Ard Biesheuvel , Heinrich Schuchardt , Nicholas Piggin , Chris Metcalf , linux-kernel@vger.kernel.org, Lucas De Marchi Subject: Re: [PATCH v2 2/2] module: Add module name to modinfo Message-ID: <20170426025759.qzdktuxvbw7me2yb@jeyu> References: <1492814127-66318-1-git-send-email-keescook@chromium.org> <1492814127-66318-3-git-send-email-keescook@chromium.org> <161cb1b4-ccdc-fba1-c272-45b8ed261cb2@jonmasters.org> <065F583B-6150-45D6-A84B-757F63A6242E@jonmasters.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Disposition: inline In-Reply-To: <065F583B-6150-45D6-A84B-757F63A6242E@jonmasters.org> X-OS: Linux jeyu 4.8.12-100.fc23.x86_64 x86_64 User-Agent: NeoMutt/20161126 (1.7.1) X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.31]); Wed, 26 Apr 2017 02:58:05 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 944 Lines: 23 +++ Jon Masters [25/04/17 03:04 -0400]: >Nevermind. Missread the patch as doing something different on first pass. It's good to give the kmod folks a heads up anyway (as name would be visible in modinfo), thanks Jon! >> On Apr 25, 2017, at 03:00, Jon Masters wrote: >> >>> On 04/21/2017 06:35 PM, Kees Cook wrote: >>> >>> Accessing the mod structure (e.g. for mod->name) prior to having completed >>> check_modstruct_version() can result in writing garbage to the error logs >>> if the layout of the mod structure loaded from disk doesn't match the >>> running kernel's mod structure layout. This kind of mismatch will become >>> much more likely if a kernel is built with different randomization seed >>> for the struct layout randomization plugin. >>> >>> Instead, add and use a new modinfo string for logging the module name. >> >> +Lucas - probably something that the modinfo kmod utility should track. >> >> Jon. >>