Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1434878AbdDZEn6 (ORCPT ); Wed, 26 Apr 2017 00:43:58 -0400 Received: from mail-io0-f170.google.com ([209.85.223.170]:36641 "EHLO mail-io0-f170.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S945818AbdDZEnu (ORCPT ); Wed, 26 Apr 2017 00:43:50 -0400 MIME-Version: 1.0 In-Reply-To: <20170426023206.raeaeqylnnjo25on@jeyu> References: <1492814127-66318-1-git-send-email-keescook@chromium.org> <20170426023206.raeaeqylnnjo25on@jeyu> From: Kees Cook Date: Tue, 25 Apr 2017 21:43:49 -0700 X-Google-Sender-Auth: o5COziBX72Vr0Id7eThL5ERlBDM Message-ID: Subject: Re: [PATCH v2 0/2] module: Add module name to modinfo To: Jessica Yu Cc: Rusty Russell , "Peter Zijlstra (Intel)" , Josh Poimboeuf , Ard Biesheuvel , Heinrich Schuchardt , Nicholas Piggin , Chris Metcalf , LKML Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 770 Lines: 29 On Tue, Apr 25, 2017 at 7:32 PM, Jessica Yu wrote: > +++ Kees Cook [21/04/17 15:35 -0700]: > >> The mod structure is accessed for the "name" field prior to validating >> sanity in check_modstruct_version(). This becomes very obvious once >> struct layout randomization is happening, so instead add the module >> name to modinfo and use that until the mod struct has been sanity-checked. >> >> -Kees >> >> v2: >> - adjusted for more odd name load failure cases; jeyu > > > Hi Kees! > > These patches look fine to me, would you mind if I held on to them > until after the upcoming merge window? (Since we're at -rc8, and I'd > still like for them to sit in -next for a while) Sure thing; I'm in no rush. :) Thanks! -Kees -- Kees Cook Pixel Security