Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1956068AbdDZGXB (ORCPT ); Wed, 26 Apr 2017 02:23:01 -0400 Received: from mail-wm0-f68.google.com ([74.125.82.68]:36387 "EHLO mail-wm0-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1956054AbdDZGWv (ORCPT ); Wed, 26 Apr 2017 02:22:51 -0400 Date: Wed, 26 Apr 2017 08:22:47 +0200 From: Ingo Molnar To: Yinghai Lu Cc: Simon Horman , kexec@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] memmap: Parse "Reserved" together with "reserved" Message-ID: <20170426062247.fbl62xrkrm7tvnga@gmail.com> References: <20170426005526.27313-1-yinghai@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170426005526.27313-1-yinghai@kernel.org> User-Agent: NeoMutt/20170113 (1.7.2) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 745 Lines: 27 * Yinghai Lu wrote: > For x86 with recent kernel after > commit 640e1b38b0 ("x86/boot/e820: Basic cleanup of e820.c") > change "reserved" to "Reserved" in /sys firmware memmap and /proc/iomem. > > So here, we add handling for that too. > > Signed-off-by: Yinghai Lu > > --- > kexec/arch/i386/crashdump-x86.c | 2 ++ > kexec/arch/ia64/kexec-ia64.c | 2 ++ > kexec/arch/mips/kexec-mips.c | 2 ++ > kexec/firmware_memmap.c | 2 ++ > 4 files changed, 8 insertions(+) I'd rather fix the bug I introduced and undo the reserved->Reserved string change in e820.c: I didn't realize that it's exposed in sysfs and had quasi-ABI consequences for kexec. Agreed? Thanks, Ingo