Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1956187AbdDZGmL convert rfc822-to-8bit (ORCPT ); Wed, 26 Apr 2017 02:42:11 -0400 Received: from mga01.intel.com ([192.55.52.88]:24992 "EHLO mga01.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S947776AbdDZGmC (ORCPT ); Wed, 26 Apr 2017 02:42:02 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.37,253,1488873600"; d="scan'208";a="93918751" From: "Lofstedt, Marta" To: Peter Zijlstra CC: "tglx@linutronix.de" , "mingo@kernel.org" , "linux-kernel@vger.kernel.org" , "ville.syrjala@linux.intel.com" , "daniel.lezcano@linaro.org" , "Wysocki, Rafael J" , "martin.peres@linux.intel.com" , "pasha.tatashin@oracle.com" , "daniel.vetter@ffwll.ch" Subject: RE: [PATCH 0/9] sched_clock fixes Thread-Topic: [PATCH 0/9] sched_clock fixes Thread-Index: AQHSurJYD2WqOBEwVkyRQSq4DZK/WqHV1b9ggAA4TgCAARr9wA== Date: Wed, 26 Apr 2017 06:41:58 +0000 Message-ID: References: <20170421145756.305735607@infradead.org> <20170425134448.hmhsnq2nnlz6jbci@hirez.programming.kicks-ass.net> In-Reply-To: <20170425134448.hmhsnq2nnlz6jbci@hirez.programming.kicks-ass.net> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiMTQ5OGM5NjItY2FkZC00ODFlLWI5MGMtZmQ3ZjQyMTBlNWQwIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX0lDIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE1LjkuNi42IiwiVHJ1c3RlZExhYmVsSGFzaCI6InRoUTNQVXB5eDdvMlJEYmhtQkx6ZkV5bWsyNGJQbEpEYWQwbmloTTFNR3c9In0= x-ctpclassification: CTP_IC dlp-product: dlpe-windows dlp-version: 10.0.102.7 dlp-reaction: no-action x-originating-ip: [163.33.239.182] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 8BIT MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1908 Lines: 42 For bisecting the regression we ran 14 test for 50 repetitions. Before the bisected regression: commit 7b09cc5a9debc86c903c2eff8f8a1fdef773c649 Author: Pavel Tatashin Date: Wed Mar 22 16:24:17 2017 -0400 sched/clock: Fix broken stable to unstable transfer there was ~0 failing test on the Core2 machine. After regression ~350 failing tests. With your patch-set ~15 failing tests. To be honest, I must say that these test used to give unstable results on the Core2. But some time ago, the results magically stabilized at ~0 fails, by timing related fixes for other issues. Ville Syrjala now has a patch-set that we believe really solves the graphics parts of the issue. However, I believe that your patch-set still improves the situation related to the tsc instability of the Core2. /Marta > -----Original Message----- > From: Peter Zijlstra [mailto:peterz@infradead.org] > Sent: Tuesday, April 25, 2017 4:45 PM > To: Lofstedt, Marta > Cc: tglx@linutronix.de; mingo@kernel.org; linux-kernel@vger.kernel.org; > ville.syrjala@linux.intel.com; daniel.lezcano@linaro.org; Wysocki, Rafael J > ; martin.peres@linux.intel.com; > pasha.tatashin@oracle.com; daniel.vetter@ffwll.ch > Subject: Re: [PATCH 0/9] sched_clock fixes > > On Tue, Apr 25, 2017 at 09:31:40AM +0000, Lofstedt, Marta wrote: > > Hi Peterz, > > > > I tested your patch-set on the same Core2 machine as where we > discovered the regression. > > With the tsc=unstable boot param that passrate has improved significantly; > 350 fails -> 15 fails. > > So is that the same as before, or still worse? I don't really have a handle on > what your benchmark is here, nor what how 'good' is defined. > > If its still worse than before, I'm completely confused. Because with > "tsc=unstable" the patch you fingered is a complete no-op (__gtod_offset > == 0).