DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 987487F7AD
Date: Wed, 26 Apr 2017 15:31:48 +0800
From: Dave Young <dyoung@redhat.com>
To: Ingo Molnar <mingo@kernel.org>
Cc: Yinghai Lu <yinghai@kernel.org>, Simon Horman <horms@verge.net.au>,
        kexec@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] memmap: Parse "Reserved" together with "reserved"
Message-ID: <20170426073148.GA7367@dhcp-128-65.nay.redhat.com>
References: <20170426005526.27313-1-yinghai@kernel.org>
 <20170426062247.fbl62xrkrm7tvnga@gmail.com>
 <20170426072846.GA7344@dhcp-128-65.nay.redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20170426072846.GA7344@dhcp-128-65.nay.redhat.com>
User-Agent: Mutt/1.7.1 (2016-10-04)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1390
Lines: 45

On 04/26/17 at 03:28pm, Dave Young wrote:
> On 04/26/17 at 08:22am, Ingo Molnar wrote:
> > 
> > * Yinghai Lu <yinghai@kernel.org> wrote:
> > 
> > > For x86 with recent kernel after
> > >  commit 640e1b38b0 ("x86/boot/e820: Basic cleanup of e820.c")
> > > change "reserved" to "Reserved" in /sys firmware memmap and /proc/iomem.
> > > 
> > > So here, we add handling for that too.
> > > 
> > > Signed-off-by: Yinghai Lu <yinghai@kernel.org>
> > > 
> > > ---
> > >  kexec/arch/i386/crashdump-x86.c |    2 ++
> > >  kexec/arch/ia64/kexec-ia64.c    |    2 ++
> > >  kexec/arch/mips/kexec-mips.c    |    2 ++
> > >  kexec/firmware_memmap.c         |    2 ++
> > >  4 files changed, 8 insertions(+)
> > 
> > I'd rather fix the bug I introduced and undo the reserved->Reserved string change 
> 
> This patch parses both 'reserved' and 'Reserved' it should be fine, but
> reverting the change in kernel sounds better..

Hmm, after press sending I noticed old kexec-tools with new kernel, it
is still a problem, so we'd better to revert the kernel changes.

> 
> > in e820.c: I didn't realize that it's exposed in sysfs and had quasi-ABI 
> > consequences for kexec.
> > 
> > Agreed?
> > 
> > Thanks,
> > 
> > 	Ingo
> > 
> > _______________________________________________
> > kexec mailing list
> > kexec@lists.infradead.org
> > http://lists.infradead.org/mailman/listinfo/kexec
> 
> Thanks
> Dave