Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1957332AbdDZI4P (ORCPT ); Wed, 26 Apr 2017 04:56:15 -0400 Received: from smtprelay2.synopsys.com ([198.182.60.111]:40566 "EHLO smtprelay.synopsys.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1951486AbdDZI4H (ORCPT ); Wed, 26 Apr 2017 04:56:07 -0400 Subject: Re: [RESEND PATCH 1/2] arc: axs10x: Add DT bindings for I2S audio playback To: Vineet Gupta , "linux-snps-arc@lists.infradead.org" References: <7ed6deaf1ae6d5819364c793835aa30316077a7e.1487787376.git.joabreu@synopsys.com> <77599cf5-33e5-2ecd-2b2a-43630195a3b8@synopsys.com> CC: Carlos Palminha , Alexey Brodkin , Rob Herring , "devicetree@vger.kernel.org" , "linux-kernel@vger.kernel.org" From: Jose Abreu Message-ID: Date: Wed, 26 Apr 2017 09:55:49 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0 MIME-Version: 1.0 In-Reply-To: <77599cf5-33e5-2ecd-2b2a-43630195a3b8@synopsys.com> Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit X-Originating-IP: [10.107.19.44] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2255 Lines: 80 Hi Vineet, On 24-04-2017 18:36, Vineet Gupta wrote: > On 04/21/2017 03:15 AM, Jose Abreu wrote: >> This patch adds the necessary DT bindings to get HDMI audio >> output in ARC AXS10x SDP. The bindings for I2S controller were >> added as well as the bindings for simple audio card. > Are these waiting on Rob or is it OK for me to pick these up for 4.12 ? Yes, I was waiting for Rob ack but he has been silent. It would be nice if these went for 4.12. Best regards, Jose Miguel Abreu > > -Vineet > >> Signed-off-by: Jose Abreu >> Acked-by: Alexey Brodkin >> Cc: Carlos Palminha >> Cc: Alexey Brodkin >> Cc: Rob Herring >> Cc: Vineet Gupta >> Cc: devicetree@vger.kernel.org >> Cc: linux-snps-arc@lists.infradead.org >> Cc: linux-kernel@vger.kernel.org >> --- >> arch/arc/boot/dts/axs10x_mb.dtsi | 22 ++++++++++++++++++---- >> 1 file changed, 18 insertions(+), 4 deletions(-) >> >> diff --git a/arch/arc/boot/dts/axs10x_mb.dtsi b/arch/arc/boot/dts/axs10x_mb.dtsi >> index d6c1bbc..9d882b1 100644 >> --- a/arch/arc/boot/dts/axs10x_mb.dtsi >> +++ b/arch/arc/boot/dts/axs10x_mb.dtsi >> @@ -149,12 +149,13 @@ >> interrupts = <14>; >> }; >> >> - i2c@0x1e000 { >> - compatible = "snps,designware-i2c"; >> + i2s: i2s@1e000 { >> + compatible = "snps,designware-i2s"; >> reg = <0x1e000 0x100>; >> - clock-frequency = <400000>; >> - clocks = <&i2cclk>; >> + clocks = <&i2sclk 0>; >> + clock-names = "i2sclk"; >> interrupts = <15>; >> + #sound-dai-cells = <0>; >> }; >> >> i2c@0x1f000 { >> @@ -174,6 +175,7 @@ >> adi,input-colorspace = "rgb"; >> adi,input-clock = "1x"; >> adi,clock-delay = <0x03>; >> + #sound-dai-cells = <0>; >> >> ports { >> #address-cells = <1>; >> @@ -295,5 +297,17 @@ >> }; >> }; >> }; >> + >> + sound_playback { >> + compatible = "simple-audio-card"; >> + simple-audio-card,name = "AXS10x HDMI Audio"; >> + simple-audio-card,format = "i2s"; >> + simple-audio-card,cpu { >> + sound-dai = <&i2s>; >> + }; >> + simple-audio-card,codec { >> + sound-dai = <&adv7511>; >> + }; >> + }; >> }; >> };