Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2997768AbdDZKVR (ORCPT ); Wed, 26 Apr 2017 06:21:17 -0400 Received: from mail-qt0-f193.google.com ([209.85.216.193]:34549 "EHLO mail-qt0-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1037687AbdDZKVI (ORCPT ); Wed, 26 Apr 2017 06:21:08 -0400 MIME-Version: 1.0 In-Reply-To: <5f628aa9-092f-52c0-549c-db7bdb7ea67b@siemens.com> References: <6e0f0b52-27a1-0ce5-c217-3aa941babe63@siemens.com> <5f628aa9-092f-52c0-549c-db7bdb7ea67b@siemens.com> From: Andy Shevchenko Date: Wed, 26 Apr 2017 13:21:06 +0300 Message-ID: Subject: Re: [PATCH] iio: adc: Add support for TI ADC1x8s102 To: Jan Kiszka Cc: Peter Meerwald-Stadler , Jonathan Cameron , linux-iio@vger.kernel.org, Linux Kernel Mailing List , Sascha Weisenberger , Andy Shevchenko Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 687 Lines: 24 On Wed, Apr 26, 2017 at 8:37 AM, Jan Kiszka wrote: > On 2017-04-25 09:31, Peter Meerwald-Stadler wrote: >> I think board-specific stuff should not go into the driver -> DT? > > Still looking for suggestions how to provide the external reference > voltage as parameter. Chip select is gone now. Unified Device Properties API. Just ret = device_property_read_u16(); if (ret) ...use default... > Also, should I suggest a device tree binding even though I have no test > case for it? My current feeling is to better leave this exercise to the > first user on a DT platform. But I prefer this one. One problem at a time. -- With Best Regards, Andy Shevchenko