Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S3000614AbdDZNnR (ORCPT ); Wed, 26 Apr 2017 09:43:17 -0400 Received: from mail-pg0-f66.google.com ([74.125.83.66]:33258 "EHLO mail-pg0-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1951950AbdDZNnK (ORCPT ); Wed, 26 Apr 2017 09:43:10 -0400 From: Wei Yongjun To: Wei-Ning Huang , Thierry Escande , Greg Kroah-Hartman Cc: Wei Yongjun , linux-kernel@vger.kernel.org Subject: [PATCH -next] firmware: Google VPD: Fix return value check in vpd_platform_init() Date: Wed, 26 Apr 2017 13:42:52 +0000 Message-Id: <20170426134252.17627-1-weiyj.lk@gmail.com> X-Mailer: git-send-email 2.9.3 MIME-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 920 Lines: 27 From: Wei Yongjun In case of error, the function platform_device_register_simple() returns ERR_PTR() and never returns NULL. The NULL test in the return value check should be replaced with IS_ERR(). Fixes: 049a59db34eb ("firmware: Google VPD sysfs driver") Signed-off-by: Wei Yongjun --- drivers/firmware/google/vpd.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/firmware/google/vpd.c b/drivers/firmware/google/vpd.c index 619f4ba..3ce8131 100644 --- a/drivers/firmware/google/vpd.c +++ b/drivers/firmware/google/vpd.c @@ -303,8 +303,8 @@ static int __init vpd_platform_init(void) struct platform_device *pdev; pdev = platform_device_register_simple("vpd", -1, NULL, 0); - if (!pdev) - return -ENODEV; + if (IS_ERR(pdev)) + return PTR_ERR(pdev); vpd_kobj = kobject_create_and_add("vpd", firmware_kobj); if (!vpd_kobj)