Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1430952AbdDZNw5 (ORCPT ); Wed, 26 Apr 2017 09:52:57 -0400 Received: from aserp1040.oracle.com ([141.146.126.69]:30037 "EHLO aserp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S3000734AbdDZNwo (ORCPT ); Wed, 26 Apr 2017 09:52:44 -0400 Subject: Re: [PATCH] x86/xen: fix xsave capability setting To: Juergen Gross , linux-kernel@vger.kernel.org, xen-devel@lists.xenproject.org References: <20170425064740.1251-1-jgross@suse.com> From: Boris Ostrovsky Message-ID: <7a749fae-4fda-c6ab-d3b0-598a7132e9de@oracle.com> Date: Wed, 26 Apr 2017 09:51:35 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.8.0 MIME-Version: 1.0 In-Reply-To: <20170425064740.1251-1-jgross@suse.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-Source-IP: aserv0021.oracle.com [141.146.126.233] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 491 Lines: 13 On 04/25/2017 02:47 AM, Juergen Gross wrote: > Commit 690b7f10b4f9f ("x86/xen: use capabilities instead of fake cpuid > values for xsave") introduced a regression as it tried to make use of > the fixup feature before it being available. > > Fall back to the old variant testing via cpuid(). > > Signed-off-by: Juergen Gross Reviewed-by: Boris Ostrovsky (This, BTW, was apparently broken on Intel as well, at least if you go back to Xen 4.1).