DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com AB91180F6D
Message-ID: <1493215062.23739.34.camel@redhat.com>
Subject: Re: [PATCH 3/6] drm: fourcc byteorder: add bigendian support to
 drm_mode_legacy_fb_format
From: Gerd Hoffmann <kraxel@redhat.com>
To: Eric Engestrom <eric.engestrom@imgtec.com>
Cc: Michel =?ISO-8859-1?Q?D=E4nzer?= <michel@daenzer.net>,
        Daniel Vetter <daniel.vetter@intel.com>, amd-gfx@lists.freedesktop.org,
        open list <linux-kernel@vger.kernel.org>,
        dri-devel@lists.freedesktop.org
Date: Wed, 26 Apr 2017 15:57:42 +0200
In-Reply-To: <20170426132801.lldz7uwwlp3euozy@imgtec.com>
References: <20170424062532.26722-1-kraxel@redhat.com>
         <20170424062532.26722-4-kraxel@redhat.com>
         <3b872a56-80b5-0c44-712f-a9517489eb24@daenzer.net>
         <1493185990.23739.7.camel@redhat.com>
         <20170426132801.lldz7uwwlp3euozy@imgtec.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8BIT
Mime-Version: 1.0
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 585
Lines: 24

> 	uint32_t drm_mode_legacy_fb_format(uint32_t bpp, uint32_t depth)
> 	{
> 		uint32_t fmt;
> 	#ifdef __BIG_ENDIAN
> 		enum { LITTLE_ENDIAN = 0 };
> 	#else
> 		enum { LITTLE_ENDIAN = 1 };
> 	#endif
> 	/* ... */
> 
> (using an enum for compile-time constness)
> 
> and then
> 	fmt = DRM_FORMAT_ARGB8888;
> becomes
> 	fmt = LITTLE_ENDIAN ? DRM_FORMAT_ARGB8888 : DRM_FORMAT_BGRA8888;
> 
> Might be easier to read than duplicating the whole switch?

Well, there are more differences, like rgb565 and xrgb2101010 not being
supported for bigendian, so it isn't *that* simple.

cheers,
  Gerd