Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S3001122AbdDZO01 (ORCPT ); Wed, 26 Apr 2017 10:26:27 -0400 Received: from mail-it0-f54.google.com ([209.85.214.54]:38482 "EHLO mail-it0-f54.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1948790AbdDZO0T (ORCPT ); Wed, 26 Apr 2017 10:26:19 -0400 MIME-Version: 1.0 In-Reply-To: <3257d22879148692da6887f89843389bd37ee877.1493060870.git.sathyanarayanan.kuppuswamy@linux.intel.com> References: <3257d22879148692da6887f89843389bd37ee877.1493060870.git.sathyanarayanan.kuppuswamy@linux.intel.com> From: Linus Walleij Date: Wed, 26 Apr 2017 16:26:17 +0200 Message-ID: Subject: Re: [PATCH v2 1/1] gpio: gpio-wcove: fix GPIO IRQ status mask To: Kuppuswamy Sathyanarayanan , Bin Gao , Mika Westerberg , Andy Shevchenko Cc: Alexandre Courbot , "linux-gpio@vger.kernel.org" , "linux-kernel@vger.kernel.org" , sathyaosid@gmail.com Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 638 Lines: 18 On Mon, Apr 24, 2017 at 9:15 PM, wrote: > From: Kuppuswamy Sathyanarayanan > > According to Whiskey Cove PMIC spec, bit 7 of GPIOIRQ0_REG belongs to > battery IO. So we should skip this bit when checking for GPIO IRQ pending > status. Otherwise, wcove_gpio_irq_handler() might go into the infinite > loop until IRQ "pending" status becomes 0. This patch fixes this issue. > > Signed-off-by: Kuppuswamy Sathyanarayanan Looks fine to me, tentatively applied. Bin, Mika, Andy, OK? Yours, Linus Walleij