Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S638362AbdDZO5I (ORCPT ); Wed, 26 Apr 2017 10:57:08 -0400 Received: from mail-pf0-f193.google.com ([209.85.192.193]:36437 "EHLO mail-pf0-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S638341AbdDZO5B (ORCPT ); Wed, 26 Apr 2017 10:57:01 -0400 From: Taeung Song To: Steven Rostedt Cc: linux-kernel@vger.kernel.org, Namhyung Kim Subject: [PATCH] parse-events: Fix the FALSE case in pevent_filter_clear_trivial() Date: Wed, 26 Apr 2017 23:55:40 +0900 Message-Id: <1493218540-12296-1-git-send-email-treeze.taeung@gmail.com> X-Mailer: git-send-email 2.7.4 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 751 Lines: 26 Currently the FILTER_TRIVIAL_FALSE hasn't break statement so if the trivial type is FALSE, it'll be hit always. So add break statement at the FALSE case to correctly remove trivial filters. Reported-by: Namhyung Kim Signed-off-by: Taeung Song --- parse-filter.c | 1 + 1 file changed, 1 insertion(+) diff --git a/parse-filter.c b/parse-filter.c index 7c214ce..c2fd26f 100644 --- a/parse-filter.c +++ b/parse-filter.c @@ -1634,6 +1634,7 @@ int pevent_filter_clear_trivial(struct event_filter *filter, case FILTER_TRIVIAL_FALSE: if (filter_type->filter->boolean.value) continue; + break; case FILTER_TRIVIAL_TRUE: if (!filter_type->filter->boolean.value) continue; -- 2.7.4