Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S965206AbdDZSmu (ORCPT ); Wed, 26 Apr 2017 14:42:50 -0400 Received: from shards.monkeyblade.net ([184.105.139.130]:59250 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S965174AbdDZSmn (ORCPT ); Wed, 26 Apr 2017 14:42:43 -0400 Date: Wed, 26 Apr 2017 14:42:41 -0400 (EDT) Message-Id: <20170426.144241.1756957005773510777.davem@davemloft.net> To: Jason@zx2c4.com Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org, security@kernel.org, sd@queasysnail.net Subject: Re: [PATCH v2] macsec: dynamically allocate space for sglist From: David Miller In-Reply-To: <20170425170818.32661-1-Jason@zx2c4.com> References: <20170425163602.GA17973@bistromath.localdomain> <20170425170818.32661-1-Jason@zx2c4.com> X-Mailer: Mew version 6.7 on Emacs 24.5 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Wed, 26 Apr 2017 11:01:18 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 490 Lines: 14 From: "Jason A. Donenfeld" Date: Tue, 25 Apr 2017 19:08:18 +0200 > We call skb_cow_data, which is good anyway to ensure we can actually > modify the skb as such (another error from prior). Now that we have the > number of fragments required, we can safely allocate exactly that amount > of memory. > > Signed-off-by: Jason A. Donenfeld > Cc: Sabrina Dubroca > Cc: security@kernel.org > Cc: stable@vger.kernel.org Applied, thanks.