From: Trond Myklebust <trondmy@primarydata.com>
To: "anna.schumaker@netapp.com" <anna.schumaker@netapp.com>,
        Trond Myklebust <trondmy@primarydata.com>,
        "fabf@skynet.be" <fabf@skynet.be>
CC: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "linux-nfs@vger.kernel.org" <linux-nfs@vger.kernel.org>
Subject: Re: [PATCH V2 linux-next] nfs: kmap can't fail
Thread-Topic: [PATCH V2 linux-next] nfs: kmap can't fail
Thread-Index: AQHSvr1FEcxlBCPgQ06Yvhuv3DNty6HYAoWA
Date: Wed, 26 Apr 2017 19:05:02 +0000
Message-ID: <1493233499.2326.1.camel@primarydata.com>
References: <20170426184516.21784-1-fabf@skynet.be>
In-Reply-To: <20170426184516.21784-1-fabf@skynet.be>
Accept-Language: en-US
Content-Language: en-US
spamdiagnosticoutput: 1:99
spamdiagnosticmetadata: NSPM
Content-ID: <0BA4C1E27BB71B44AD48FB244D874E7E@namprd11.prod.outlook.com>
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-originalarrivaltime: 26 Apr 2017 19:05:02.2931
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 03193ed6-8726-4bb3-a832-18ab0d28adb7
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR11MB1359
X-MC-Unique: 0U1hd05sP1KXKPsjwc9z7w-1
Content-Type: text/plain; charset=UTF-8
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Transfer-Encoding: 8bit
X-MIME-Autoconverted: from base64 to 8bit by mail.home.local id v3QJ5Su1000428
Content-Length: 1005
Lines: 39

On Wed, 2017-04-26 at 20:45 +0200, Fabian Frederick wrote:
> Remove NULL test on kmap()
> 
> Signed-off-by: Fabian Frederick <fabf@skynet.be>
> ---
> V2: Remove ptr and return kmap(page) directly
> (Suggested by Anna Schumaker)
> 
>  fs/nfs/dir.c | 6 +-----
>  1 file changed, 1 insertion(+), 5 deletions(-)
> 
> diff --git a/fs/nfs/dir.c b/fs/nfs/dir.c
> index 3a188cb..12ed806b 100644
> --- a/fs/nfs/dir.c
> +++ b/fs/nfs/dir.c
> @@ -175,13 +175,9 @@ typedef struct {
>  static
>  struct nfs_cache_array *nfs_readdir_get_array(struct page *page)
>  {
> -	void *ptr;
>  	if (page == NULL)
>  		return ERR_PTR(-EIO);
> -	ptr = kmap(page);
> -	if (ptr == NULL)
> -		return ERR_PTR(-ENOMEM);
> -	return ptr;
> +	return kmap(page);
>  }
>  
>  static

There seems little value in having a wrapper to kmap... Can we perhaps
instead just get rid of both nfs_readdir_get_array and
nfs_readdir_release_array?

-- 
Trond Myklebust
Linux NFS client maintainer, PrimaryData
trond.myklebust@primarydata.com