Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S967177AbdDZUS5 (ORCPT <rfc822;w@1wt.eu>);
        Wed, 26 Apr 2017 16:18:57 -0400
Received: from mail.andi.de1.cc ([85.214.239.24]:45224 "EHLO
        h2641619.stratoserver.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S965095AbdDZUSv (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Wed, 26 Apr 2017 16:18:51 -0400
Date: Wed, 26 Apr 2017 22:18:43 +0200
From: Andreas Kemnade <andreas@kemnade.info>
To: Joe Perches <joe@perches.com>
Cc: linux-kernel@vger.kernel.org, Russell King <linux@armlinux.org.uk>,
        linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] ARM: Fix __show_regs output timestamps
Message-ID: <20170426221843.4f2677bc@aktux>
In-Reply-To: <61817479ac8c4c6c8be702d2e2136fddac1b1821.1493228290.git.joe@perches.com>
References: <61817479ac8c4c6c8be702d2e2136fddac1b1821.1493228290.git.joe@perches.com>
X-Mailer: Claws Mail 3.11.1 (GTK+ 2.24.25; x86_64-pc-linux-gnu)
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
 boundary="Sig_/iz1JlnEdU2ei9qGTQxq5Fk1"; protocol="application/pgp-signature"
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 3095
Lines: 84

--Sig_/iz1JlnEdU2ei9qGTQxq5Fk1
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: quoted-printable

On Wed, 26 Apr 2017 10:39:49 -0700
Joe Perches <joe@perches.com> wrote:

> Multiple line formats are not preferred as the second and
> subsequent lines may not have timestamps.
>=20
> Lacking timestamps makes reading the output a bit difficult.
> This also makes arm/arm64 output more similar.
>=20
> Previous:
>=20
> [ 1514.093231] pc : [<bf79c304>]    lr : [<bf79ced8>]    psr: a00f0013
> sp : ecdd7e20  ip : 00000000  fp : ffffffff
>=20
> New:
>=20
> [ 1514.093231] pc : [<bf79c304>]    lr : [<bf79ced8>]    psr: a00f0013
> [ 1514.105316] sp : ecdd7e20  ip : 00000000  fp : ffffffff
>=20
[  102.669036] PC is at hso_start_net_device+0x50/0xc0 [hso]
[  102.674835] LR is at hso_net_open+0x68/0x84 [hso]
[  102.679809] pc : [<bf785304>]    lr : [<bf785ed8>]    psr: a00b0013
[  102.686462] sp : ed047e20  ip : 00000000  fp : ffffffff

yes, the kernel oopses in a nicer way.

Tested-by: Andreas Kemnade <andreas@kemnade.info>

Regards,
Andreas Kemnade

> Signed-off-by: Joe Perches <joe@perches.com>
> ---
>  arch/arm/kernel/process.c | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
>=20
> diff --git a/arch/arm/kernel/process.c b/arch/arm/kernel/process.c
> index 939e8b58c59d..151cece4a293 100644
> --- a/arch/arm/kernel/process.c
> +++ b/arch/arm/kernel/process.c
> @@ -123,10 +123,10 @@ void __show_regs(struct pt_regs *regs)
> =20
>  	print_symbol("PC is at %s\n", instruction_pointer(regs));
>  	print_symbol("LR is at %s\n", regs->ARM_lr);
> -	printk("pc : [<%08lx>]    lr : [<%08lx>]    psr: %08lx\n"
> -	       "sp : %08lx  ip : %08lx  fp : %08lx\n",
> -		regs->ARM_pc, regs->ARM_lr, regs->ARM_cpsr,
> -		regs->ARM_sp, regs->ARM_ip, regs->ARM_fp);
> +	printk("pc : [<%08lx>]    lr : [<%08lx>]    psr: %08lx\n",
> +	       regs->ARM_pc, regs->ARM_lr, regs->ARM_cpsr);
> +	printk("sp : %08lx  ip : %08lx  fp : %08lx\n",
> +	       regs->ARM_sp, regs->ARM_ip, regs->ARM_fp);
>  	printk("r10: %08lx  r9 : %08lx  r8 : %08lx\n",
>  		regs->ARM_r10, regs->ARM_r9,
>  		regs->ARM_r8);


--Sig_/iz1JlnEdU2ei9qGTQxq5Fk1
Content-Type: application/pgp-signature
Content-Description: OpenPGP digital signature

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2

iQIcBAEBCAAGBQJZAQCmAAoJEInxNTv1CwY0jBoP/1XFr5syLso2J32vAtTBXhUF
zONYGgVy5vq0VJkxcncvAHifrdbxmROW0wRTN5515UQG93E9RXotJEKVCxQc0vbD
kyMoNEAZdKW4/venQ0tNZoP5WLq+Fg1LCZjQmPNMdOISQ4uWlKJKBjUgPERNN/e8
Q6nhp/no81t9Ujq+g5U9slJuELBxjJdPZPnbcCe0Eq+U/pvjQuH3UoDS9vidDn/c
t0YVi+8vO/sYt6xScgmEKCQhKrLQKEwvsz+oKU7l5IoS45nFuWicVyrXwuka8oGW
m/i0b3bS3WZuk0ErW2o42SQKcYYK8UNJb2OV+BJuByPk+EjuEYsakbW5L5P3v5IB
YkYN5MYdRF+c9v9P3w6eJ3BFJejwfm4KaIYzQ7pOIByJ8aYByvrgxR8zny4OZ3n0
MfDX4clOH2K9nKp4S3qwFGuSxTrI45n9ZlotAmHCS0MKVpQg0JRz4EqP9fjal9uY
Wvu63kahYTah7qvCfLaRlcbGY6kKw9j/FZnwRHm8fnk34KiH90qoaQaizxZncF+w
oJL6CdWs3rKMjTsmdmoZPAstkqok7WfBugPvSh3jmNfe2wehpaeGukakKMApSRG1
upzO3eXWypK52Ku7UBAp6qj9FByIeXCSMhddOPThgBjH/n95pHYY4Dx8hYp3z8rB
GXhBDhgZjqikbSqMnPxh
=aVZr
-----END PGP SIGNATURE-----

--Sig_/iz1JlnEdU2ei9qGTQxq5Fk1--