Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S967790AbdDZVbj (ORCPT ); Wed, 26 Apr 2017 17:31:39 -0400 Received: from mail-qt0-f193.google.com ([209.85.216.193]:35336 "EHLO mail-qt0-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S967769AbdDZVbc (ORCPT ); Wed, 26 Apr 2017 17:31:32 -0400 MIME-Version: 1.0 In-Reply-To: <1493042662-30435-1-git-send-email-agust@denx.de> References: <1493042662-30435-1-git-send-email-agust@denx.de> From: Andy Shevchenko Date: Thu, 27 Apr 2017 00:31:30 +0300 Message-ID: Subject: Re: [PATCH] gpiolib: Add stubs for gpiod lookup table interface To: Anatolij Gustschin Cc: "linux-gpio@vger.kernel.org" , Linus Walleij , Alexandre Courbot , "linux-kernel@vger.kernel.org" Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1215 Lines: 36 On Mon, Apr 24, 2017 at 5:04 PM, Anatolij Gustschin wrote: > Add stubs for gpiod_add_lookup_table() and gpiod_remove_lookup_table() > for the !GPIOLIB case to prevent build errors. Also add prototypes. One nit below, otherwise FWIW: Reviewed-by: Andy Shevchenko Linus, it would be nice if are okay with this approach. It will fix that one user which might break a buiid on some kernel configurations. > > Signed-off-by: Anatolij Gustschin > --- > include/linux/gpio/consumer.h | 15 +++++++++++++++ > 1 file changed, 15 insertions(+) > > diff --git a/include/linux/gpio/consumer.h b/include/linux/gpio/consumer.h > index 933d936..6c0cc67 100644 > --- a/include/linux/gpio/consumer.h > +++ b/include/linux/gpio/consumer.h > @@ -144,6 +144,11 @@ struct gpio_desc *devm_fwnode_get_index_gpiod_from_child(struct device *dev, > enum gpiod_flags flags, > const char *label); > +struct gpiod_lookup_table; > #else /* CONFIG_GPIOLIB */ > +struct gpiod_lookup_table; No need to duplicate this. Just move out of #ifdef. -- With Best Regards, Andy Shevchenko