Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1032465AbdDZXCz (ORCPT <rfc822;w@1wt.eu>);
        Wed, 26 Apr 2017 19:02:55 -0400
Received: from mga03.intel.com ([134.134.136.65]:59716 "EHLO mga03.intel.com"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1754561AbdDZXCt (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Wed, 26 Apr 2017 19:02:49 -0400
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.37,256,1488873600"; 
   d="scan'208";a="94609179"
Message-ID: <1493247761.10302.129.camel@linux.intel.com>
Subject: Re: [PATCH V2 linux-next] staging: media: atomisp: kmap() can't fail
From: Alan Cox <alan@linux.intel.com>
To: Fabian Frederick <fabf@skynet.be>,
        Mauro Carvalho Chehab <mchehab@kernel.org>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Jan Kara <jack@suse.com>, linux-kernel@vger.kernel.org
Date: Thu, 27 Apr 2017 00:02:41 +0100
In-Reply-To: <20170426184423.21301-1-fabf@skynet.be>
References: <20170426184423.21301-1-fabf@skynet.be>
Organization: Intel Corporation
Content-Type: text/plain; charset="UTF-8"
X-Mailer: Evolution 3.20.5 (3.20.5-1.fc24) 
Mime-Version: 1.0
Content-Transfer-Encoding: 8bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 336
Lines: 12

On Wed, 2017-04-26 at 20:44 +0200, Fabian Frederick wrote:
> There's no need to check kmap() return value because it won't fail.
> If it's highmem mapping, it will receive virtual address
> or a new one; if it's lowmem, all kernel pages are already being
> mapped.
> 
> (Thanks to Jan Kara for explanations)
> 

Thanks - queued.

Alan