Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1033354AbdD0AuG (ORCPT ); Wed, 26 Apr 2017 20:50:06 -0400 Received: from mx2.suse.de ([195.135.220.15]:35421 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S933868AbdD0At4 (ORCPT ); Wed, 26 Apr 2017 20:49:56 -0400 Date: Thu, 27 Apr 2017 02:49:52 +0200 From: "Luis R. Rodriguez" To: "Luis R. Rodriguez" , Hans de Goede , Arend Van Spriel Cc: gregkh@linuxfoundation.org, wagi@monom.org, dwmw2@infradead.org, rafal@milecki.pl, arend.vanspriel@broadcom.com, rjw@rjwysocki.net, yi1.li@linux.intel.com, atull@opensource.altera.com, moritz.fischer@ettus.com, pmladek@suse.com, johannes.berg@intel.com, emmanuel.grumbach@intel.com, luciano.coelho@intel.com, kvalo@codeaurora.org, luto@kernel.org, takahiro.akashi@linaro.org, dhowells@redhat.com, pjones@redhat.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH v6 5/5] brcmfmac: don't warn user if requested nvram fails Message-ID: <20170427004952.GF28800@wotan.suse.de> References: <20170330032514.17173-1-mcgrof@kernel.org> <20170330032514.17173-6-mcgrof@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20170330032514.17173-6-mcgrof@kernel.org> User-Agent: Mutt/1.6.0 (2016-04-01) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 701 Lines: 17 On Wed, Mar 29, 2017 at 08:25:14PM -0700, Luis R. Rodriguez wrote: > The requested nvram is optional, don't nag users about this. > Additionally, the new driver data API enables us to let the API > deal with the freeing of the nvram for us if we happen to free > it immediately on the consumer callback, this driver does that > so take advantage of this feature. > > Originally based on patches by Rafał Miłecki. > > Signed-off-by: Luis R. Rodriguez On another thread [0] Hans has pointed out this firmware is in fact not optional for certain devices, so will drop this patch from the series. https://lkml.kernel.org/r/09063fc2-af77-ced6-ed90-ab20e2884969@redhat.com Luis