Date: Wed, 26 Apr 2017 22:47:20 -0400
From: Steven Rostedt <rostedt@goodmis.org>
To: Taeung Song <treeze.taeung@gmail.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] plugin python: Adjust the handling after PyRun_String()
 failed
Message-ID: <20170426224720.58733a9a@grimm.local.home>
In-Reply-To: <1493250381-25278-1-git-send-email-treeze.taeung@gmail.com>
References: <1493250381-25278-1-git-send-email-treeze.taeung@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1191
Lines: 48

On Thu, 27 Apr 2017 08:46:21 +0900
Taeung Song <treeze.taeung@gmail.com> wrote:

> Even though PyRun_String() failed,
> just 0 will be returned but we need to return -1
> that means error status, so fix it.
> 
> Signed-off-by: Taeung Song <treeze.taeung@gmail.com>
> ---
>  plugin_python.c | 5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)
> 
> diff --git a/plugin_python.c b/plugin_python.c
> index 2997679..dcfad0f 100644
> --- a/plugin_python.c
> +++ b/plugin_python.c
> @@ -24,7 +24,7 @@ static int load_plugin(struct pevent *pevent, const char *path,
>  			const char *name, void *data)
>  {
>  	PyObject *globals = data;
> -	int err;
> +	int err, ret = 0;

Hmm, we can either reuse err.

>  	int len = strlen(path) + strlen(name) + 2;
>  	int nlen = strlen(name) + 1;
>  	char *full = malloc(len);
> @@ -50,12 +50,13 @@ static int load_plugin(struct pevent *pevent, const char *path,
>  	if (!res) {
>  		fprintf(stderr, "failed loading %s\n", full);
>  		PyErr_Print();
> +		ret = -1;
>  	} else
>  		Py_DECREF(res);
>  
>  	free(load);
>  
> -	return 0;
> +	return ret;

or do a: return res ? 0 : -1;

-- Steve

>  }
>  
>  int PEVENT_PLUGIN_LOADER(struct pevent *pevent)