Date: Thu, 27 Apr 2017 00:19:18 -0400
From: Dave Jones <davej@codemonkey.org.uk>
To: Al Viro <viro@ZenIV.linux.org.uk>
Cc: Linux Kernel <linux-kernel@vger.kernel.org>
Subject: Re: iov_iter_pipe warning.
Message-ID: <20170427041918.ts33j22wm352xjni@codemonkey.org.uk>
Mail-Followup-To: Dave Jones <davej@codemonkey.org.uk>,
        Al Viro <viro@ZenIV.linux.org.uk>,
        Linux Kernel <linux-kernel@vger.kernel.org>
References: <20170412005853.vqyuo6722tmthn5u@codemonkey.org.uk>
 <20170412011532.GN29622@ZenIV.linux.org.uk>
 <20170412022911.nhefjqlnyrk3n7rr@codemonkey.org.uk>
 <20170412025842.GO29622@ZenIV.linux.org.uk>
 <20170412143519.4hh36l3egozgdrll@codemonkey.org.uk>
 <20170412152600.GP29622@ZenIV.linux.org.uk>
 <20170412162709.bn5qfk4seues3yos@codemonkey.org.uk>
 <20170412170723.GQ29622@ZenIV.linux.org.uk>
 <20170412190318.srkkdytf2ebrjzrg@codemonkey.org.uk>
 <20170421175430.GT29622@ZenIV.linux.org.uk>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20170421175430.GT29622@ZenIV.linux.org.uk>
User-Agent: NeoMutt/20170306 (1.8.0)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 700
Lines: 16

On Fri, Apr 21, 2017 at 06:54:30PM +0100, Al Viro wrote:
 > On Wed, Apr 12, 2017 at 03:03:18PM -0400, Dave Jones wrote:
 > 
 > > Well it's been running an hour without incident, which looks promising.
 > > I'll leave it run, but I'd say you're on the right track given how quick
 > > it reproduced so far.
 > 
 > Could you try this and see if it works?  What happens is that unlike
 > e.g. generic_file_read_iter/generic_file_write_iter, NFS O_DIRECT handling
 > does not make sure that iov_iter had been advanced by the amount
 > actually transferred - it is left advanced by the amount *requested*.

Sorry for delay on this, been sick.   Just gave this a run for 12 hours.
Looks good to me.

	Dave