DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com DB36C804F2
Message-ID: <1493275550.31995.31.camel@redhat.com>
Subject: Re: [PATCH 3/6] drm: fourcc byteorder: add bigendian support to
 drm_mode_legacy_fb_format
From: Gerd Hoffmann <kraxel@redhat.com>
To: Michel =?ISO-8859-1?Q?D=E4nzer?= <michel@daenzer.net>
Cc: Daniel Vetter <daniel.vetter@intel.com>,
        dri-devel@lists.freedesktop.org,
        open list <linux-kernel@vger.kernel.org>,
        amd-gfx@lists.freedesktop.org
Date: Thu, 27 Apr 2017 08:45:50 +0200
In-Reply-To: <6bd62182-0de5-a8a7-78c3-029fc73ecc91@daenzer.net>
References: <20170424062532.26722-1-kraxel@redhat.com>
         <20170424062532.26722-4-kraxel@redhat.com>
         <3b872a56-80b5-0c44-712f-a9517489eb24@daenzer.net>
         <1493185990.23739.7.camel@redhat.com>
         <8f91cc58-16dc-5899-66b6-06d430a18801@daenzer.net>
         <1493208671.23739.19.camel@redhat.com>
         <6bd62182-0de5-a8a7-78c3-029fc73ecc91@daenzer.net>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8BIT
Mime-Version: 1.0
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1279
Lines: 36

  Hi,

> > That is done using the RADEON_TILING_SWAP_{16,32}BIT flag mentioned in
> > another thread?
> 
> Right.
> 
> 
> > What about dumb bos?  You've mentioned the swap flag isn't used for
> > those.  Which implies they are in little endian byte order (both gpu and
> > cpu view).
> 
> Right, AFAICT from looking at the code.

Ok.

And I also don't see an easy way to make them big endian (cpu view)
using swapping with the existing drm interfaces, given we apply a format
when we put the bo into use as framebuffer, not when creating it.  So
userspace can: (1) create dumb bo, (2) map bo, (3) write something bo,
(4) create fb + attach to crtc.  And at (3) we don't know the format
yet, so we can't configure swapping accordingly.

So just not using the swapping indeed looks like the only sensible
option.  Which in turn implies there is no BGRA8888 support for dumb
bos.  Hmm, I can see the problem.  Userspace expectation appears to be
that ADDFB configures a native endian framebuffer, which the driver
simply can't do on bigendian.

So, what can/should the driver do here?  Throw errors for ADDFB and
force userspace to use ADDFB2?  From a design point of view the best
option, but in the other hand I suspect that could break the xorg radeon
driver ...

cheers,
  Gerd