Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1033897AbdD0KHO (ORCPT ); Thu, 27 Apr 2017 06:07:14 -0400 Received: from mail-oi0-f43.google.com ([209.85.218.43]:34908 "EHLO mail-oi0-f43.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752150AbdD0KHG (ORCPT ); Thu, 27 Apr 2017 06:07:06 -0400 MIME-Version: 1.0 In-Reply-To: <1493212192-7930-2-git-send-email-daniel.baluta@nxp.com> References: <1493212192-7930-1-git-send-email-daniel.baluta@nxp.com> <1493212192-7930-2-git-send-email-daniel.baluta@nxp.com> From: Arnd Bergmann Date: Thu, 27 Apr 2017 12:07:05 +0200 X-Google-Sender-Auth: vtVZjQwcdVkoFDaOKjujC_AgYNY Message-ID: Subject: Re: [PATCH v2 1/2] ASoC: codec: wm9860: avoid maybe-uninitialized warning To: Daniel Baluta Cc: Mark Brown , Takashi Iwai , Charles Keepax , Liam Girdwood , patches@opensource.wolfsonmicro.com, alsa-devel@alsa-project.org, Linux Kernel Mailing List Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1408 Lines: 36 On Wed, Apr 26, 2017 at 3:09 PM, Daniel Baluta wrote: > The new PLL configuration code triggers a harmless warning: > > sound/soc/codecs/wm8960.c: In function 'wm8960_configure_clocking': > sound/soc/codecs/wm8960.c:735:3: error: 'best_freq_out' may be used > uninitialized in this function [-Werror=maybe-uninitialized] > wm8960_set_pll(codec, freq_in, best_freq_out); > ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > sound/soc/codecs/wm8960.c:699:12: note: 'best_freq_out' was declared > here > > Fix this by reworking the code such that: > > 1) When there is no PLL freq available return -EINVAL and make > sure *bclk_idx, *dac_idx, *sysclk_idx are initialized with > invalid values. > > 2) When there is a PLL freq available initialize *bclk_idx, > *dac_idx and *sysclk_idx with correct values and immediately > return the freq available. > > Fixes: 84fdc00d519f ("ASoC: codec: wm9860: Refactor PLL out freq search") > Fixes: 303e8954af8d ("ASoC: codec: wm8960: Stop when a matching PLL freq is found") > Suggested-by: Arnd Bergmann > Signed-off-by: Daniel Baluta Looks good to me. Let me know if you need me to test this more thoroughly with randconfig builds, otherwise I'll assume it's fine and it will get tested once it shows up in linux-next. Acked-by: Arnd Bergmann Thanks for addressing this, Arnd