From: Daniel Baluta <daniel.baluta@nxp.com>
To: "arnd@arndb.de" <arnd@arndb.de>
CC: "lgirdwood@gmail.com" <lgirdwood@gmail.com>,
        "ckeepax@opensource.wolfsonmicro.com" 
        <ckeepax@opensource.wolfsonmicro.com>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "patches@opensource.wolfsonmicro.com" 
        <patches@opensource.wolfsonmicro.com>,
        "broonie@kernel.org" <broonie@kernel.org>,
        "tiwai@suse.com" <tiwai@suse.com>,
        "alsa-devel@alsa-project.org" <alsa-devel@alsa-project.org>
Subject: Re: [PATCH v2 1/2] ASoC: codec: wm9860: avoid maybe-uninitialized
 warning
Thread-Topic: [PATCH v2 1/2] ASoC: codec: wm9860: avoid maybe-uninitialized
 warning
Thread-Index: AQHSvo5vaXdBb7uE70uGvaRpJ5+026HY/u6AgAAPlgA=
Date: Thu, 27 Apr 2017 11:02:52 +0000
Message-ID: <1493290972.18400.40.camel@nxp.com>
References: <1493212192-7930-1-git-send-email-daniel.baluta@nxp.com>
         <1493212192-7930-2-git-send-email-daniel.baluta@nxp.com>
         <CAK8P3a1ZGTyjhAzy4h2D10+-dFNi6o_qe0pY9Wx5wYXZK6ObDw@mail.gmail.com>
In-Reply-To: <CAK8P3a1ZGTyjhAzy4h2D10+-dFNi6o_qe0pY9Wx5wYXZK6ObDw@mail.gmail.com>
Accept-Language: en-US
Content-Language: en-US
spamdiagnosticoutput: 1:99
spamdiagnosticmetadata: NSPM
Content-Type: text/plain; charset="utf-8"
Content-ID: <E07B3C5EF9F09D46BFE5512A93220712@eurprd04.prod.outlook.com>
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-originalarrivaltime: 27 Apr 2017 11:02:52.7606
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM3PR04MB500
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Transfer-Encoding: 8bit
X-MIME-Autoconverted: from base64 to 8bit by mail.home.local id v3RB6CUc006738
Content-Length: 1814
Lines: 52

On Jo, 2017-04-27 at 12:07 +0200, Arnd Bergmann wrote:
> On Wed, Apr 26, 2017 at 3:09 PM, Daniel Baluta <daniel.baluta@nxp.com
> > wrote:
> > 
> > The new PLL configuration code triggers a harmless warning:
> > 
> > sound/soc/codecs/wm8960.c: In function 'wm8960_configure_clocking':
> > sound/soc/codecs/wm8960.c:735:3: error: 'best_freq_out' may be used
> > uninitialized in this function [-Werror=maybe-uninitialized]
> >    wm8960_set_pll(codec, freq_in, best_freq_out);
> >    ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> > sound/soc/codecs/wm8960.c:699:12: note: 'best_freq_out' was
> > declared
> > here
> > 
> > Fix this by reworking the code such that:
> > 
> > 1) When there is no PLL freq available return -EINVAL and make
> > sure *bclk_idx, *dac_idx, *sysclk_idx are initialized with
> > invalid values.
> > 
> > 2) When there is a PLL freq available initialize *bclk_idx,
> > *dac_idx and *sysclk_idx with correct values and immediately
> > return the freq available.
> > 
> > Fixes: 84fdc00d519f ("ASoC: codec: wm9860: Refactor PLL out freq
> > search")
> > Fixes: 303e8954af8d ("ASoC: codec: wm8960: Stop when a matching PLL
> > freq is found")
> > Suggested-by: Arnd Bergmann <arnd@arndb.de>
> > Signed-off-by: Daniel Baluta <daniel.baluta@nxp.com>
> Looks good to me. Let me know if you need me to test this more
> thoroughly
> with randconfig builds, otherwise I'll assume it's fine and it will
> get tested once
> it shows up in linux-next.
> 
> Acked-by: Arnd Bergmann <arnd@arndb.de>
> 

Hi Arnd, 

Thanks for doing this. I wouldn't expect randconfigs builds to show
other issues.

Anyhow, would like to see if with your compiler there are no warnings
for the second patch of the series:

http://mailman.alsa-project.org/pipermail/alsa-devel/2017-April/120177.html

thanks,
Daniel.