DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com CEE556584E
Date: Thu, 27 Apr 2017 13:33:04 +0200
From: Andrew Jones <drjones@redhat.com>
To: Radim =?utf-8?B?S3LEjW3DocWZ?= <rkrcmar@redhat.com>
Cc: linux-kernel@vger.kernel.org, kvm@vger.kernel.org,
        Christoffer Dall <cdall@linaro.org>,
        Marc Zyngier <marc.zyngier@arm.com>,
        Paolo Bonzini <pbonzini@redhat.com>,
        Christian Borntraeger <borntraeger@de.ibm.com>,
        Cornelia Huck <cornelia.huck@de.ibm.com>,
        James Hogan <james.hogan@imgtec.com>,
        Paul Mackerras <paulus@ozlabs.org>
Subject: Re: [PATCH v2 1/9] KVM: add kvm_{test,clear}_request to replace
 {test,clear}_bit
Message-ID: <20170427113304.2sxivi4vol3kbxhk@kamzik.brq.redhat.com>
References: <20170426203227.12321-1-rkrcmar@redhat.com>
 <20170426203227.12321-2-rkrcmar@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <20170426203227.12321-2-rkrcmar@redhat.com>
User-Agent: Mutt/1.6.0.1 (2016-04-01)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 578
Lines: 16

On Wed, Apr 26, 2017 at 10:32:19PM +0200, Radim Krčmář wrote:
> Users were expected to use kvm_check_request() for testing and clearing,
> but request have expanded their use since then and some users want to
> only test or do a faster clear.
> 
> Make sure that requests are not directly accessed with bit operations.

This isn't 100% accurate, as the set_bit changes are made in the next
patch.

> 
> Reviewed-by: Christian Borntraeger <borntraeger@de.ibm.com>
> Signed-off-by: Radim Krčmář <rkrcmar@redhat.com>

Otherwise
Reviewed-by: Andrew Jones <drjones@redhat.com>