Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S939125AbdD0LjL convert rfc822-to-8bit (ORCPT ); Thu, 27 Apr 2017 07:39:11 -0400 Received: from mx0a-001b2d01.pphosted.com ([148.163.156.1]:36661 "EHLO mx0a-001b2d01.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S936006AbdD0Li7 (ORCPT ); Thu, 27 Apr 2017 07:38:59 -0400 Date: Thu, 27 Apr 2017 13:38:38 +0200 From: Cornelia Huck To: Radim =?UTF-8?B?S3LEjW3DocWZ?= Cc: linux-kernel@vger.kernel.org, kvm@vger.kernel.org, Christoffer Dall , Andrew Jones , Marc Zyngier , Paolo Bonzini , Christian Borntraeger , James Hogan , Paul Mackerras Subject: Re: [PATCH v2 1/9] KVM: add kvm_{test,clear}_request to replace {test,clear}_bit In-Reply-To: <20170426203227.12321-2-rkrcmar@redhat.com> References: <20170426203227.12321-1-rkrcmar@redhat.com> <20170426203227.12321-2-rkrcmar@redhat.com> Organization: IBM Deutschland Research & Development GmbH Vorsitzende des Aufsichtsrats: Martina Koederitz =?UTF-8?B?R2VzY2jDpGZ0c2bDvGhydW5nOg==?= Dirk Wittkopp Sitz der Gesellschaft: =?UTF-8?B?QsO2Ymxpbmdlbg==?= Registergericht: Amtsgericht Stuttgart, HRB 243294 X-Mailer: Claws Mail 3.11.1 (GTK+ 2.24.23; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT X-TM-AS-GCONF: 00 x-cbid: 17042711-0020-0000-0000-00000354429D X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 17042711-0021-0000-0000-000041791A08 Message-Id: <20170427133838.35d1232e.cornelia.huck@de.ibm.com> X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2017-04-27_08:,, signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 suspectscore=0 malwarescore=0 phishscore=0 adultscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1703280000 definitions=main-1704270196 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 996 Lines: 24 On Wed, 26 Apr 2017 22:32:19 +0200 Radim Krčmář wrote: > Users were expected to use kvm_check_request() for testing and clearing, > but request have expanded their use since then and some users want to > only test or do a faster clear. > > Make sure that requests are not directly accessed with bit operations. > > Reviewed-by: Christian Borntraeger > Signed-off-by: Radim Krčmář > --- > arch/mips/kvm/emulate.c | 2 +- > arch/powerpc/kvm/book3s_pr.c | 2 +- > arch/powerpc/kvm/book3s_pr_papr.c | 2 +- > arch/powerpc/kvm/booke.c | 4 ++-- > arch/powerpc/kvm/powerpc.c | 2 +- > arch/s390/kvm/kvm-s390.c | 2 +- > arch/x86/kvm/vmx.c | 2 +- > arch/x86/kvm/x86.c | 8 ++++---- > include/linux/kvm_host.h | 14 ++++++++++++-- > 9 files changed, 24 insertions(+), 14 deletions(-) Reviewed-by: Cornelia Huck