Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S968555AbdD0LyZ (ORCPT ); Thu, 27 Apr 2017 07:54:25 -0400 Received: from mail-wr0-f178.google.com ([209.85.128.178]:32830 "EHLO mail-wr0-f178.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S967252AbdD0LyK (ORCPT ); Thu, 27 Apr 2017 07:54:10 -0400 MIME-Version: 1.0 Reply-To: mtk.manpages@gmail.com In-Reply-To: References: <149324135581.24512.17200609423997054366.stgit@warthog.procyon.org.uk> From: "Michael Kerrisk (man-pages)" Date: Thu, 27 Apr 2017 13:53:47 +0200 Message-ID: Subject: Re: [PATCH] statx: Kill fd-with-NULL-path support in favour of AT_EMPTY_PATH To: Linus Torvalds Cc: David Howells , Al Viro , linux-man , Linux API , Eric Sandeen , Linux Kernel Mailing List , fstests , linux-fsdevel , Michael Kerrisk , Christoph Hellwig Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 735 Lines: 24 On 27 April 2017 at 00:03, Linus Torvalds wrote: > On Wed, Apr 26, 2017 at 2:15 PM, David Howells wrote: >> [!] NOTE: This breaks UAPI introduced in 4.11-rc1. > > Ugh. > > I'm, applying this now, so that we don't end up with a released kernel > that supports the NULL filename thing. > > I'm not happy about the timing though. And I hope nobody started using > statx() outside of tests. Agreed on the timing. Late review on my part didn't help. But, also, David's fix is not quite right. I will send a patch. Cheers, Michael -- Michael Kerrisk Linux man-pages maintainer; http://www.kernel.org/doc/man-pages/ Linux/UNIX System Programming Training: http://man7.org/training/