Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S968603AbdD0MEc (ORCPT ); Thu, 27 Apr 2017 08:04:32 -0400 Received: from mail-oi0-f67.google.com ([209.85.218.67]:36763 "EHLO mail-oi0-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1033994AbdD0MES (ORCPT ); Thu, 27 Apr 2017 08:04:18 -0400 MIME-Version: 1.0 In-Reply-To: <20170427115513.GH14088@mtr-leonro.local> References: <20170427110421.2431598-1-arnd@arndb.de> <20170427115513.GH14088@mtr-leonro.local> From: Arnd Bergmann Date: Thu, 27 Apr 2017 14:04:15 +0200 X-Google-Sender-Auth: hqIrBnpMkrxuJb4XTuSRmqogDaU Message-ID: Subject: Re: [PATCH net-next] mlx5: work around unused function warning To: Leon Romanovsky Cc: Saeed Mahameed , Matan Barak , "David S. Miller" , Erez Shitrit , Dan Carpenter , Stephen Hemminger , Networking , linux-rdma@vger.kernel.org, Linux Kernel Mailing List Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1129 Lines: 25 On Thu, Apr 27, 2017 at 1:55 PM, Leon Romanovsky wrote: > On Thu, Apr 27, 2017 at 01:04:02PM +0200, Arnd Bergmann wrote: >> The previous patch addressed a sparse warning but replaced it with a >> compiler warning when CONFIG_MODULES is disabled: >> >> drivers/net/ethernet/mellanox/mlx5/core/ipoib.c:485:13: error: 'mlx5_rdma_netdev_free' defined but not used [-Werror=unused-function] >> drivers/net/ethernet/mellanox/mlx5/core/ipoib.c:423:27: error: 'mlx5_rdma_netdev_alloc' defined but not used [-Werror=unused-function] >> >> We should never export 'static' functions, so this makes them global >> again but hides them in another #ifdef like the change before. >> >> Fixes: a7082ef066f0 ("mlx5: hide unused functions") >> Signed-off-by: Arnd Bergmann > > Hi Arnd, > > Thanks for the patch, but Stephen and Saeed already sent patch similar to it. > http://marc.info/?l=linux-netdev&m=149288674816288&w=2 That link is for the patch that introduced the warning that I'm fixing here, it showed up yesterday in linux-next. Did you misread my patch, or just give the wrong link? Arnd