Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S939201AbdD0MSg (ORCPT ); Thu, 27 Apr 2017 08:18:36 -0400 Received: from mx08-00178001.pphosted.com ([91.207.212.93]:13003 "EHLO mx07-00178001.pphosted.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S933442AbdD0MS1 (ORCPT ); Thu, 27 Apr 2017 08:18:27 -0400 Subject: Re: [PATCH] mtd: spi-nor: stm32: remove broken MODULE_ALIAS To: Arnd Bergmann , Cyrille Pitchen , Marek Vasut References: <20170427111001.2587551-1-arnd@arndb.de> CC: David Woodhouse , Brian Norris , Boris Brezillon , Richard Weinberger , Maxime Coquelin , Alexandre Torgue , , , From: Ludovic BARRE Message-ID: Date: Thu, 27 Apr 2017 14:17:23 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.8.0 MIME-Version: 1.0 In-Reply-To: <20170427111001.2587551-1-arnd@arndb.de> Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [10.75.127.46] X-ClientProxiedBy: SFHDAG3NODE1.st.com (10.75.127.7) To SFHDAG6NODE1.st.com (10.75.127.16) X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2017-04-27_08:,, signatures=0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1324 Lines: 35 thanks a lot Arnd Oops, I've not tested in Module :-(. Just tested in built-in, and used bind/unbind and device tree overlays. BR Ludo On 04/27/2017 01:09 PM, Arnd Bergmann wrote: > The MODULE_ALIAS statement refers to a macro that has never been defined > in this driver, causing a build error: > > drivers/mtd/spi-nor/stm32-quadspi.c:694:150: error: expected ',' or ';' before 'DRIVER_NAME' > > Unless there is a specific alias we need other then the driver name, > we don't need an alias here and can simply remove the line to fix the > build. > > Fixes: dc5e400611c5 ("mtd: spi-nor: add driver for STM32 quad spi flash controller") > Signed-off-by: Arnd Bergmann > --- > drivers/mtd/spi-nor/stm32-quadspi.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/mtd/spi-nor/stm32-quadspi.c b/drivers/mtd/spi-nor/stm32-quadspi.c > index 90d9152ddf98..1056e7408d2a 100644 > --- a/drivers/mtd/spi-nor/stm32-quadspi.c > +++ b/drivers/mtd/spi-nor/stm32-quadspi.c > @@ -691,7 +691,6 @@ static struct platform_driver stm32_qspi_driver = { > }; > module_platform_driver(stm32_qspi_driver); > > -MODULE_ALIAS("platform:" DRIVER_NAME); > MODULE_AUTHOR("Ludovic Barre "); > MODULE_DESCRIPTION("STMicroelectronics STM32 quad spi driver"); > MODULE_LICENSE("GPL v2");