Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1034066AbdD0Mmo (ORCPT ); Thu, 27 Apr 2017 08:42:44 -0400 Received: from mail-io0-f171.google.com ([209.85.223.171]:36732 "EHLO mail-io0-f171.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1032716AbdD0Mm1 (ORCPT ); Thu, 27 Apr 2017 08:42:27 -0400 MIME-Version: 1.0 In-Reply-To: References: <20170425150005.GR24360@codeblueprint.co.uk> <3fe85a2e-c846-5545-7896-c838bec6f251@nexus-software.ie> From: Ard Biesheuvel Date: Thu, 27 Apr 2017 13:42:25 +0100 Message-ID: Subject: Re: [PATCH v2 0/3] efi: add support for non-standard capsule headers To: "Bryan O'Donoghue" Cc: Matt Fleming , Jan Kiszka , "linux-efi@vger.kernel.org" , Linux Kernel Mailing List , Andy Shevchenko , Hock Leong Kweh , Borislav Petkov , Sascha Weisenberger Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 911 Lines: 29 On 27 April 2017 at 13:46, Bryan O'Donoghue wrote: > On 25/04/17 16:08, Ard Biesheuvel wrote: >> >> On 25 April 2017 at 16:07, Bryan O'Donoghue >>> >>> I'm OOO until Thursday however, I could test this out on a Galileo for >>> you with the CSH stripped out. As Jan has pointed out Galileo aka Quark >>> x1000 non-secure (not to be called insecure) will just skips past the >>> CSH anyway - so - we can give it a conformant capsule by stripping the >>> CSH junk off the top. >>> >>> How about you queue it up and I'll let you know if there's a problem >>> Thursday? >>> >> >> That would be highly appreciated, thanks. >> > > Looks good. > > I stripped the header > dd skip=1024 bs=1 if=firmware.cap of=firmware-no-csh.cap > > Downloaded the now conformat capsule and update/reflash succeeded. > Thanks. I will go ahead and queue these patches for v4.13 with your Tested-by added.