Date: Thu, 27 Apr 2017 16:13:12 +0300
From: Leon Romanovsky <leonro@mellanox.com>
To: Arnd Bergmann <arnd@arndb.de>
CC: Saeed Mahameed <saeedm@mellanox.com>,
        Matan Barak <matanb@mellanox.com>,
        "David S. Miller" <davem@davemloft.net>,
        Erez Shitrit <erezsh@mellanox.com>,
        Dan Carpenter <dan.carpenter@oracle.com>,
        Stephen Hemminger <stephen@networkplumber.org>,
        Networking <netdev@vger.kernel.org>, <linux-rdma@vger.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH net-next] mlx5: work around unused function warning
Message-ID: <20170427131312.GI14088@mtr-leonro.local>
References: <20170427110421.2431598-1-arnd@arndb.de>
 <20170427115513.GH14088@mtr-leonro.local>
 <CAK8P3a0kX4uNLBvLAHrhtmUc7eBLmD6dXA8=xxY+xJ4OsGFJbg@mail.gmail.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
        protocol="application/pgp-signature"; boundary="hdMwqcnXK86+cyrC"
Content-Disposition: inline
In-Reply-To: <CAK8P3a0kX4uNLBvLAHrhtmUc7eBLmD6dXA8=xxY+xJ4OsGFJbg@mail.gmail.com>
User-Agent: Mutt/1.8.0 (2017-02-23)
SpamDiagnosticOutput: 1:99
SpamDiagnosticMetadata: NSPM
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Apr 2017 13:13:01.5320 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-Transport-CrossTenantHeadersStamped: HE1PR0501MB1929
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 2677
Lines: 63

--hdMwqcnXK86+cyrC
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Thu, Apr 27, 2017 at 02:04:15PM +0200, Arnd Bergmann wrote:
> On Thu, Apr 27, 2017 at 1:55 PM, Leon Romanovsky <leonro@mellanox.com> wrote:
> > On Thu, Apr 27, 2017 at 01:04:02PM +0200, Arnd Bergmann wrote:
> >> The previous patch addressed a sparse warning but replaced it with a
> >> compiler warning when CONFIG_MODULES is disabled:
> >>
> >> drivers/net/ethernet/mellanox/mlx5/core/ipoib.c:485:13: error: 'mlx5_rdma_netdev_free' defined but not used [-Werror=unused-function]
> >> drivers/net/ethernet/mellanox/mlx5/core/ipoib.c:423:27: error: 'mlx5_rdma_netdev_alloc' defined but not used [-Werror=unused-function]
> >>
> >> We should never export 'static' functions, so this makes them global
> >> again but hides them in another #ifdef like the change before.
> >>
> >> Fixes: a7082ef066f0 ("mlx5: hide unused functions")
> >> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> >
> > Hi Arnd,
> >
> > Thanks for the patch, but Stephen and Saeed already sent patch similar to it.
> > http://marc.info/?l=linux-netdev&m=149288674816288&w=2
>
> That link is for the patch that introduced the warning that I'm fixing here,
> it showed up yesterday in linux-next.
>
> Did you misread my patch, or just give the wrong link?

Sorry, I misread you patch, because I prepared patch which add users for
these functions and didn't notice both "static" and EXPORT_SYMBOLS at the same time.
I will send it in a couple of minutes.

Thanks

>
>       Arnd
> --
> To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

--hdMwqcnXK86+cyrC
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAEBCAAdFiEEkhr/r4Op1/04yqaB5GN7iDZyWKcFAlkB7mgACgkQ5GN7iDZy
WKfasg//c/K7nxVllkX26KHp0Vpmh1yNiqs/LJEG3vBc2GPv6hDytmupE0TMUEIU
bo6oHowYUCe3MnBHNLeNDo9Bumq5kGwsmwPv6UP73NxqPE97qmhDAiXX0abBmrin
GD76DejozoHEelGImceTrzFyZTRGbhH3SdBDRB1hs3Kz+VrTK+iJvFCVyz7/XbSK
utC7AiQLDd8AAAmkzhITo++bHiJN/k2ks/2DGcDhhlDMCZv/9NzSU972SpGDj4NI
tvaUDXHOweh8/hWnAkvvZqSNF8FZgCXNivhbSiyLup12t2MKOksbdyV9QkwahcJU
vrx5s34ZFjV+RjFH8HrJGFYORf08DIFWHRV1qHWDK7FcSAhJOS9WITn1GKByl2R2
qAQUX8Qhksg83AQs75EZDZNC7rj3RG2tB/nvxzDFWOagxRKi4L5ngYm2UFZYhG6M
Oy8e/MynLN1O3KnaK5nrTz4sQvuFVhcyabsBX6Ooz6ixUIrNR1ghJP6uXRmi4Er4
ti8BNIxmLmoWmKyQOCLkrwm0Up6VTK/eEsIj8TCMBvgVYLj+huyDnyE8syiFhVY3
sFgOSuqkpoZL01AjIUZqQqzwLasGZuturYGZMnsVGp/+IVoIxNyruwGBgO3nW2Gm
mkrwCfdMu4hgGZsYVrtCNyqPmxt2H2IIm/y8Fu/lndm4MHqZUGc=
=hT5S
-----END PGP SIGNATURE-----

--hdMwqcnXK86+cyrC--