Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1162056AbdD0O3t (ORCPT ); Thu, 27 Apr 2017 10:29:49 -0400 Received: from mail-out.m-online.net ([212.18.0.9]:51091 "EHLO mail-out.m-online.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932774AbdD0O3k (ORCPT ); Thu, 27 Apr 2017 10:29:40 -0400 X-Auth-Info: T9J4GDkUqwEMjEXOcU5tZO5/llskiujcD8R/te9KFiQ= Date: Thu, 27 Apr 2017 16:29:36 +0200 From: Anatolij Gustschin To: Andy Shevchenko Cc: Linus Walleij , Alexandre Courbot , "linux-gpio@vger.kernel.org" , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH v2] gpiolib: Add stubs for gpiod lookup table interface Message-ID: <20170427162936.7064810f@crub> In-Reply-To: <20170427162534.0499344f@crub> References: <1493275956-14759-1-git-send-email-agust@denx.de> <20170427162534.0499344f@crub> X-Mailer: Claws Mail 3.13.2 (GTK+ 2.24.30; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 700 Lines: 29 On Thu, 27 Apr 2017 16:25:34 +0200 Anatolij Gustschin agust@denx.de wrote: >On Thu, 27 Apr 2017 17:07:23 +0300 >Andy Shevchenko andy.shevchenko@gmail.com wrote: ... >>static inline void gpiod_add_lookup_table(struct gpiod_lookup_table *table) {} >>static inline void gpiod_remove_lookup_table(struct gpiod_lookup_table >>*table) {} >>#endif /* !GPIOLIB */ >> >>P.S. please notice how I put the stubs. It would be good to keep them >>in two lines. > >this will exceed 80 char line limit. I'll go with static inline void gpiod_add_lookup_table(struct gpiod_lookup_table *table) {} static inline void gpiod_remove_lookup_table(struct gpiod_lookup_table *table) {} Is it okay? Thanks, Anatolij