Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753528AbdD0OaJ (ORCPT ); Thu, 27 Apr 2017 10:30:09 -0400 Received: from metis.ext.4.pengutronix.de ([92.198.50.35]:40299 "EHLO metis.ext.4.pengutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1162064AbdD0OaB (ORCPT ); Thu, 27 Apr 2017 10:30:01 -0400 Subject: Re: [PATCH net-next] can: fix build error without CONFIG_PROC_FS To: Arnd Bergmann , Oliver Hartkopp , "David S. Miller" References: <20170427142146.3107957-1-arnd@arndb.de> Cc: Thomas Gleixner , Cong Wang , Mario Kicherer , Eric Dumazet , linux-can@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org From: Marc Kleine-Budde Message-ID: <937e9144-c06c-d265-29eb-a1c6f96b6f89@pengutronix.de> Date: Thu, 27 Apr 2017 16:29:46 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.8.0 MIME-Version: 1.0 In-Reply-To: <20170427142146.3107957-1-arnd@arndb.de> Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="cjiqFJODSB0jwJxw4bPpuA5JnNGst9li1" X-SA-Exim-Connect-IP: 2001:67c:670:201:5054:ff:fe8d:eefb X-SA-Exim-Mail-From: mkl@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 3130 Lines: 82 This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --cjiqFJODSB0jwJxw4bPpuA5JnNGst9li1 Content-Type: multipart/mixed; boundary="fJFcolD8RlvilxddcSU38f0QA68Wtpxeb"; protected-headers="v1" From: Marc Kleine-Budde To: Arnd Bergmann , Oliver Hartkopp , "David S. Miller" Cc: Thomas Gleixner , Cong Wang , Mario Kicherer , Eric Dumazet , linux-can@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Message-ID: <937e9144-c06c-d265-29eb-a1c6f96b6f89@pengutronix.de> Subject: Re: [PATCH net-next] can: fix build error without CONFIG_PROC_FS References: <20170427142146.3107957-1-arnd@arndb.de> In-Reply-To: <20170427142146.3107957-1-arnd@arndb.de> --fJFcolD8RlvilxddcSU38f0QA68Wtpxeb Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Hello Arnd, On 04/27/2017 04:21 PM, Arnd Bergmann wrote: > The procfs dir entry was added inside of an #ifdef, causing a build err= or > when we try to access it without CONFIG_PROC_FS set: >=20 > net/can/bcm.c:1541:14: error: 'struct netns_can' has no member named 'b= cmproc_dir' > net/can/bcm.c: In function 'bcm_connect': > net/can/bcm.c:1601:14: error: 'struct netns_can' has no member named 'b= cmproc_dir' > net/can/bcm.c: In function 'canbcm_pernet_init': > net/can/bcm.c:1696:11: error: 'struct netns_can' has no member named 'b= cmproc_dir' > net/can/bcm.c: In function 'canbcm_pernet_exit': > net/can/bcm.c:1707:15: error: 'struct netns_can' has no member named 'b= cmproc_dir' >=20 > This adds the same #ifdef around all users of the pointer. Alternativel= y > we could move the pointer outside of the #ifdef. >=20 > Fixes: 384317ef4187 ("can: network namespace support for CAN_BCM protoc= ol") > Signed-off-by: Arnd Bergmann A fix for this problem is part of the pull request I send to David earlier today: https://www.mail-archive.com/netdev@vger.kernel.org/msg165764.html regards, Marc --=20 Pengutronix e.K. | Marc Kleine-Budde | Industrial Linux Solutions | Phone: +49-231-2826-924 | Vertretung West/Dortmund | Fax: +49-5121-206917-5555 | Amtsgericht Hildesheim, HRA 2686 | http://www.pengutronix.de | --fJFcolD8RlvilxddcSU38f0QA68Wtpxeb-- --cjiqFJODSB0jwJxw4bPpuA5JnNGst9li1 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCgAdFiEE4bay/IylYqM/npjQHv7KIOw4HPYFAlkCAFoACgkQHv7KIOw4 HPbH1Qf9H/EHdYLAXPhJ0cPqBRw7k9EaW4VmElKqf7w4MAUA1J3p5aUZzEL2uY8C 337RyNA9eTXybmJtDZRbb5DKPxC+2d6aJSoY9jUJ3vWIF2w1ZrfGJEtg5vYYX4J1 O4CYMlrPyR93ZMReCePlOxOGG6WLijH00B1MCFB2uAslEGqmOup3yTNliA2p+SHY yKM4rSmnWEVn2G57CQahB54wIg6ZbdG1v64DwLzwg7a6qem2T9XEnpF7Tex+SF0/ 5RWYdQIkXkC6Awor+H1BR6FwKX4MOwdExlXQhcHf0hZMycqKp7hgWs59Cz33uDOJ xCafKWHEAu5fjMEub8Yo4Z0TIFLApw== =MP4x -----END PGP SIGNATURE----- --cjiqFJODSB0jwJxw4bPpuA5JnNGst9li1--