Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S939379AbdD0OrR (ORCPT ); Thu, 27 Apr 2017 10:47:17 -0400 Received: from mail-qt0-f194.google.com ([209.85.216.194]:35583 "EHLO mail-qt0-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S939354AbdD0OrG (ORCPT ); Thu, 27 Apr 2017 10:47:06 -0400 MIME-Version: 1.0 In-Reply-To: <20170427162936.7064810f@crub> References: <1493275956-14759-1-git-send-email-agust@denx.de> <20170427162534.0499344f@crub> <20170427162936.7064810f@crub> From: Andy Shevchenko Date: Thu, 27 Apr 2017 17:47:05 +0300 Message-ID: Subject: Re: [PATCH v2] gpiolib: Add stubs for gpiod lookup table interface To: Anatolij Gustschin Cc: Linus Walleij , Alexandre Courbot , "linux-gpio@vger.kernel.org" , "linux-kernel@vger.kernel.org" Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 910 Lines: 34 On Thu, Apr 27, 2017 at 5:29 PM, Anatolij Gustschin wrote: > On Thu, 27 Apr 2017 16:25:34 +0200 > Anatolij Gustschin agust@denx.de wrote: > >>On Thu, 27 Apr 2017 17:07:23 +0300 >>Andy Shevchenko andy.shevchenko@gmail.com wrote: > ... >>>static inline void gpiod_add_lookup_table(struct gpiod_lookup_table *table) {} >>>static inline void gpiod_remove_lookup_table(struct gpiod_lookup_table >>>*table) {} >>>#endif /* !GPIOLIB */ >>> >>>P.S. please notice how I put the stubs. It would be good to keep them >>>in two lines. >> >>this will exceed 80 char line limit. Not for many (unimportant) symbols. > I'll go with > > static inline > void gpiod_add_lookup_table(struct gpiod_lookup_table *table) {} > > static inline > void gpiod_remove_lookup_table(struct gpiod_lookup_table *table) {} > > Is it okay? Whatever Linus prefers. I'm fine with either. -- With Best Regards, Andy Shevchenko